Skip to content

chore(ci): update create-github-app-token to suport Node.js 24#6846

Open
Thalarion wants to merge 1 commit intomainfrom
thalarion/fix_nodejs_20_warning_in_crowdin_pull
Open

chore(ci): update create-github-app-token to suport Node.js 24#6846
Thalarion wants to merge 1 commit intomainfrom
thalarion/fix_nodejs_20_warning_in_crowdin_pull

Conversation

@Thalarion
Copy link
Copy Markdown
Contributor

@Thalarion Thalarion commented Apr 28, 2026

See
image
here
https://github.com/trezor/trezor-firmware/actions/runs/24768702531

I tested Crowdin - pull translations (manual) action and it worked as expected.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 28, 2026

Walkthrough

Four GitHub Actions workflow files are updated to upgrade the actions/create-github-app-token action from version 2.2.1 to 3.1.1. Alongside the version update, the input parameter name is changed from app-id to client-id across all workflows, while the secret source remains unchanged. No other workflow logic or functionality is modified.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is minimal and lacks required sections from the template. Core information about PR setup, development status, and testing is missing. Add the required sections: assign yourself, add to Firmware project with Priority/Team/Sprint, set development status to 'Needs Review', and include 'Notes for QA' section with testing instructions.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating create-github-app-token action to a newer version (v3.1.1) that supports Node.js 24, addressing deprecation warnings across four workflow files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch thalarion/fix_nodejs_20_warning_in_crowdin_pull

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@trezor-bot trezor-bot Bot added this to Firmware Apr 28, 2026
@github-project-automation github-project-automation Bot moved this to 🔎 Needs review in Firmware Apr 28, 2026
@Thalarion Thalarion added the ci Continuous Integration (CI) related label Apr 28, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 28, 2026

en main(all)

model device_test click_test persistence_test
T2T1 test(all) main(all) test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all) test(all) main(all)

Latest CI run: 25075468448

@Thalarion Thalarion changed the title chore(ci): create-github-app-token to suport Node.js 24 chore(ci): update create-github-app-token to suport Node.js 24 Apr 28, 2026
@Thalarion Thalarion force-pushed the thalarion/fix_nodejs_20_warning_in_crowdin_pull branch from 4b37969 to 476a242 Compare April 28, 2026 20:02
@Thalarion Thalarion force-pushed the thalarion/fix_nodejs_20_warning_in_crowdin_pull branch from 476a242 to 2916a86 Compare April 28, 2026 20:16
@Thalarion Thalarion requested a review from M1nd3r April 28, 2026 20:18
@Thalarion Thalarion marked this pull request as ready for review April 28, 2026 20:19
Copy link
Copy Markdown
Contributor

@M1nd3r M1nd3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The commit hashes are valid and expected.
  • I was not able to verify, whether the secret TREZOR_BOT_APP_ID is of type client-id.

nit:
Consider being more verbose in commit messages - e.g. specifying from-to versions when updating something and using the actual name of what you are updating. (example)

uses: actions/create-github-app-token@1b10c78c7865c340bc4f6099eb2f838309f1e8c3 # actions/create-github-app-token@v3.1.1
with:
app-id: ${{ secrets.TREZOR_BOT_APP_ID }}
client-id: ${{ secrets.TREZOR_BOT_APP_ID }}
Copy link
Copy Markdown
Contributor

@M1nd3r M1nd3r Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to use a different secret here.

IIUC, client-id and app-id are two different things. It was already possible to use client-id instead of app-id in some contexts - so I am not sure, whether secrets.TREZOR_BOT_APP_ID is app-id or client-id.

@vdovhanych Could you please confirm what type the secrets.TREZOR_BOT_APP_ID is - and if it is an app-id, could you please store client-id in secrets.TREZOR_BOT_CLIENT_ID? Thanks!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it to client-id based on this warning:
image

App ID still works as a fallback, but changing the secret to client ID is better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration (CI) related

Projects

Status: 🔎 Needs review

Development

Successfully merging this pull request may close these issues.

2 participants