chore(ci): update create-github-app-token to suport Node.js 24#6846
chore(ci): update create-github-app-token to suport Node.js 24#6846
Conversation
WalkthroughFour GitHub Actions workflow files are updated to upgrade the Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
| model | device_test | click_test | persistence_test |
|---|---|---|---|
| T2T1 | test(all) main(all) ![]() |
test(all) main(all) ![]() |
test(all) main(all) ![]() |
| T3B1 | test(all) main(all) ![]() |
test(all) main(all) ![]() |
test(all) main(all) ![]() |
| T3T1 | test(all) main(all) ![]() |
test(all) main(all) ![]() |
test(all) main(all) ![]() |
| T3W1 | test(all) main(all) ![]() |
test(all) main(all) ![]() |
test(all) main(all) ![]() |
Latest CI run: 25075468448
4b37969 to
476a242
Compare
[no changelog]
476a242 to
2916a86
Compare
M1nd3r
left a comment
There was a problem hiding this comment.
- The commit hashes are valid and expected.
- I was not able to verify, whether the secret
TREZOR_BOT_APP_IDis of typeclient-id.
nit:
Consider being more verbose in commit messages - e.g. specifying from-to versions when updating something and using the actual name of what you are updating. (example)
| uses: actions/create-github-app-token@1b10c78c7865c340bc4f6099eb2f838309f1e8c3 # actions/create-github-app-token@v3.1.1 | ||
| with: | ||
| app-id: ${{ secrets.TREZOR_BOT_APP_ID }} | ||
| client-id: ${{ secrets.TREZOR_BOT_APP_ID }} |
There was a problem hiding this comment.
We might want to use a different secret here.
IIUC, client-id and app-id are two different things. It was already possible to use client-id instead of app-id in some contexts - so I am not sure, whether secrets.TREZOR_BOT_APP_ID is app-id or client-id.
@vdovhanych Could you please confirm what type the secrets.TREZOR_BOT_APP_ID is - and if it is an app-id, could you please store client-id in secrets.TREZOR_BOT_CLIENT_ID? Thanks!
There was a problem hiding this comment.
I changed it to client-id based on this warning:

App ID still works as a fallback, but changing the secret to client ID is better.




































See

here
https://github.com/trezor/trezor-firmware/actions/runs/24768702531
I tested
Crowdin - pull translations (manual)action and it worked as expected.