Skip to content

fix(webapp): disable resizable panel cookie saves to prevent large cookies causing HTTP 431 errors#3282

Merged
matt-aitken merged 1 commit intomainfrom
fix/resizeable-panel-fix-large-cookies
Mar 27, 2026
Merged

fix(webapp): disable resizable panel cookie saves to prevent large cookies causing HTTP 431 errors#3282
matt-aitken merged 1 commit intomainfrom
fix/resizeable-panel-fix-large-cookies

Conversation

@ericallam
Copy link
Copy Markdown
Member

No description provided.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 8eca6486-d220-47d5-bfb7-5f8ff65909ed

📥 Commits

Reviewing files that changed from the base of the PR and between 8244ac6 and fcfc18e.

📒 Files selected for processing (1)
  • apps/webapp/app/components/primitives/Resizable.tsx
💤 Files with no reviewable changes (1)
  • apps/webapp/app/components/primitives/Resizable.tsx
📜 Recent review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (17)
  • GitHub Check: units / internal / 🧪 Unit Tests: Internal (2, 8)
  • GitHub Check: units / internal / 🧪 Unit Tests: Internal (7, 8)
  • GitHub Check: units / internal / 🧪 Unit Tests: Internal (6, 8)
  • GitHub Check: units / internal / 🧪 Unit Tests: Internal (3, 8)
  • GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (4, 8)
  • GitHub Check: units / internal / 🧪 Unit Tests: Internal (1, 8)
  • GitHub Check: units / internal / 🧪 Unit Tests: Internal (4, 8)
  • GitHub Check: units / internal / 🧪 Unit Tests: Internal (5, 8)
  • GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (1, 8)
  • GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (2, 8)
  • GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (5, 8)
  • GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (7, 8)
  • GitHub Check: units / packages / 🧪 Unit Tests: Packages (1, 1)
  • GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (3, 8)
  • GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
  • GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
  • GitHub Check: typecheck / typecheck

Walkthrough

A single line was removed from the ResizablePanelGroup component in apps/webapp/app/components/primitives/Resizable.tsx. The removal eliminates a conditional assignment of the autosaveStrategy prop to the underlying PanelGroup, which previously set the strategy to "cookie" when autosaveId was provided or left it undefined otherwise. No public API changes were made; the component's exported types remain unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is entirely missing. No information was provided about testing, changes, or context for the fix. Add a complete description following the repository template, including: issue reference, testing steps, changelog entry explaining the cookie save removal, and any relevant context about the HTTP 431 error issue.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing autosave cookie functionality from resizable panels to prevent HTTP 431 errors caused by oversized cookies.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/resizeable-panel-fix-large-cookies

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

View 1 additional finding in Devin Review.

Open in Devin Review

Comment on lines 10 to 15
"flex w-full overflow-hidden data-[panel-group-direction=vertical]:flex-col",
className
)}
autosaveStrategy={props.autosaveId ? "cookie" : undefined}
{...props}
/>
);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Fix effectiveness depends on library default for autosaveStrategy

The PR removes the explicit autosaveStrategy={props.autosaveId ? "cookie" : undefined} prop, but callers still pass autosaveId to ResizablePanelGroup (e.g., apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.runs.$runParam/route.tsx:511, :587, :780, and apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.prompts.$promptSlug/route.tsx:589, :596, :1439). If react-window-splitter@0.4.1 defaults autosaveStrategy to "cookie" when autosaveId is provided, the removal would be a no-op and cookies would still be written, meaning the HTTP 431 errors would persist. The library's actual default should be verified to confirm this fix is effective.

(Refers to lines 7-15)

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@matt-aitken matt-aitken merged commit 21cf8f9 into main Mar 27, 2026
40 checks passed
@matt-aitken matt-aitken deleted the fix/resizeable-panel-fix-large-cookies branch March 27, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants