fix(webapp): disable resizable panel cookie saves to prevent large cookies causing HTTP 431 errors#3282
Conversation
…okies causing HTTP 431 errors
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (17)
WalkthroughA single line was removed from the Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| "flex w-full overflow-hidden data-[panel-group-direction=vertical]:flex-col", | ||
| className | ||
| )} | ||
| autosaveStrategy={props.autosaveId ? "cookie" : undefined} | ||
| {...props} | ||
| /> | ||
| ); |
There was a problem hiding this comment.
🚩 Fix effectiveness depends on library default for autosaveStrategy
The PR removes the explicit autosaveStrategy={props.autosaveId ? "cookie" : undefined} prop, but callers still pass autosaveId to ResizablePanelGroup (e.g., apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.runs.$runParam/route.tsx:511, :587, :780, and apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.prompts.$promptSlug/route.tsx:589, :596, :1439). If react-window-splitter@0.4.1 defaults autosaveStrategy to "cookie" when autosaveId is provided, the removal would be a no-op and cookies would still be written, meaning the HTTP 431 errors would persist. The library's actual default should be verified to confirm this fix is effective.
(Refers to lines 7-15)
Was this helpful? React with 👍 or 👎 to provide feedback.
No description provided.