-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table: Row Action Column Accessibility issues #2887
Merged
coliff
merged 9 commits into
main
from
2886-table-row-action-column-accessibility-issues
Nov 25, 2024
Merged
Table: Row Action Column Accessibility issues #2887
coliff
merged 9 commits into
main
from
2886-table-row-action-column-accessibility-issues
Nov 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-column' of https://github.com/trimble-oss/modus-web-components into 1922-table-uneven-width-on-row-selection-and-row-action-column
…-column' into 2886-table-row-action-column-accessibility-issues
✅ Deploy Preview for moduswebcomponents ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
coliff
previously approved these changes
Sep 25, 2024
This PR will have to wait until #2874 is merged. |
stencil-workspace/src/components/modus-table/parts/modus-table-header.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The accessibility issue has been resolved. Moved for PR Review.
saravananrmsmy
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
References
Fixes #2886
Type of change
How Has This Been Tested?
Checklist