Add request filter for early user and query parsing #748
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| /* | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package io.trino.gateway.ha.router; | ||
|
|
||
| import com.google.inject.Inject; | ||
| import com.google.inject.Singleton; | ||
|
|
||
| import java.util.List; | ||
| import java.util.Set; | ||
| import java.util.regex.Pattern; | ||
| import java.util.regex.PatternSyntaxException; | ||
|
|
||
| import static com.google.common.collect.ImmutableList.toImmutableList; | ||
| import static io.trino.gateway.ha.handler.HttpUtils.OAUTH_PATH; | ||
| import static io.trino.gateway.ha.handler.HttpUtils.TRINO_UI_PATH; | ||
| import static io.trino.gateway.ha.handler.HttpUtils.UI_API_STATS_PATH; | ||
| import static io.trino.gateway.ha.handler.HttpUtils.V1_INFO_PATH; | ||
| import static io.trino.gateway.ha.handler.HttpUtils.V1_NODE_PATH; | ||
| import static io.trino.gateway.ha.handler.HttpUtils.V1_QUERY_PATH; | ||
| import static java.util.Objects.requireNonNull; | ||
|
|
||
| /** | ||
| * A filter component that determines whether a given path should be whitelisted | ||
| * for routing to Trino clusters. | ||
| */ | ||
| @Singleton | ||
| public class PathFilter | ||
| { | ||
| private final Set<String> statementPaths; | ||
| private final List<Pattern> extraWhitelistPatterns; | ||
|
|
||
| @Inject | ||
| public PathFilter( | ||
| List<String> statementPaths, | ||
| List<String> extraWhitelistPaths) | ||
| { | ||
| this.statementPaths = Set.copyOf(requireNonNull(statementPaths, "Required configuration 'statementPaths' can't be null")); | ||
|
Member
There was a problem hiding this comment. Use |
||
| this.extraWhitelistPatterns = requireNonNull(extraWhitelistPaths, "extraWhitelistPaths cannot be null").stream() | ||
| .map(pattern -> { | ||
| try { | ||
| return Pattern.compile(pattern); | ||
| } | ||
| catch (PatternSyntaxException e) { | ||
| throw new IllegalArgumentException("Invalid regex pattern: " + pattern, e); | ||
| } | ||
| }) | ||
| .collect(toImmutableList()); | ||
| } | ||
|
|
||
| /** | ||
| * Determines if the given path is whitelisted for routing to backend. | ||
| * | ||
| * @param path the request path to check | ||
| * @return true if the path should be routed to backend, false otherwise | ||
| */ | ||
| public boolean isPathWhiteListed(String path) | ||
| { | ||
| return statementPaths.stream().anyMatch(path::startsWith) | ||
| || path.startsWith(V1_QUERY_PATH) | ||
| || path.startsWith(TRINO_UI_PATH) | ||
| || path.startsWith(V1_INFO_PATH) | ||
| || path.startsWith(V1_NODE_PATH) | ||
| || path.startsWith(UI_API_STATS_PATH) | ||
| || path.startsWith(OAUTH_PATH) | ||
| || extraWhitelistPatterns.stream().anyMatch(pattern -> pattern.matcher(path).matches()); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please inject
HaGatewayConfigurationinstead.