[Connector] Trino Pulsar Plugin #23439
Conversation
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
github-actions
bot
added
docs
ui
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
3 similar comments
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
| @@ -240,7 +240,7 @@ public Slice getSlice() { | |||
| } | |||
|
|
|||
| @Override | |||
| public Block getBlock() { | |||
| public Object getObject() { | |||
There was a problem hiding this comment.
@lhotari Before I proceed, what will be an alternative?
| @@ -252,7 +252,7 @@ private static Slice getSlice(Object value, Type type, String columnName) { | |||
|
|
|||
| if (type instanceof VarbinaryType) { | |||
| if (value instanceof ByteBuffer) { | |||
| return Slices.wrappedBuffer((ByteBuffer) value); | |||
| return Slices.wrappedHeapBuffer((ByteBuffer) value); | |||
There was a problem hiding this comment.
@lhotari Before I proceed, what will be an alternative?
| @@ -390,17 +390,17 @@ private static Block serializeMap(BlockBuilder parentBlockBuilder, Object value, | |||
| blockBuilder = type.createBlockBuilder(null, 1); | |||
| } | |||
|
|
|||
| BlockBuilder entryBuilder = blockBuilder.beginBlockEntry(); | |||
| BlockBuilder entryBuilder = blockBuilder;//blockBuilder.beginBlockEntry(); | |||
| for (Map.Entry<?, ?> entry : map.entrySet()) { | |||
There was a problem hiding this comment.
@lhotari Before I proceed, what will be an alternative?
| @@ -316,7 +316,7 @@ private static Block serializeLongDecimal( | |||
| final ByteBuffer buffer = (ByteBuffer) value; | |||
| type.writeObject(blockBuilder, Int128.fromBigEndian(buffer.array())); | |||
| if (parentBlockBuilder == null) { | |||
| return blockBuilder.getSingleValueBlock(0); | |||
| return blockBuilder.build();//.getSingleValueBlock(0); | |||
| } | |||
There was a problem hiding this comment.
@lhotari Before I proceed, what will be an alternative?
| for (Map.Entry<?, ?> entry : map.entrySet()) { | ||
| if (entry.getKey() != null) { | ||
| keyType.writeSlice(entryBuilder, truncateToLength(utf8Slice(entry.getKey().toString()), keyType)); | ||
| serializeObject(entryBuilder, entry.getValue(), valueType, columnName); | ||
| } | ||
| } | ||
| blockBuilder.closeEntry(); | ||
| //blockBuilder.closeEntry(); | ||
|
|
There was a problem hiding this comment.
@lhotari Before I proceed, what will be an alternative?
|
|
||
| if (parentBlockBuilder == null) { | ||
| return blockBuilder.getObject(0, Block.class); | ||
| return blockBuilder.build();//.getObject(0, Block.class); | ||
| } |
There was a problem hiding this comment.
@lhotari Before I proceed, what will be an alternative?
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
https://github.com/eaba/trino-plugin-pulsar DescriptionThis is the example I wish I had when I was starting to learn about Trino:
[CLONED] |
Fix #7852
Add a plugin for Apache Pulsar.
It's mostly a migration of original Pulsar PrestoSQL connector with update for all the package to Trino and fix dependency and code style issues.
This plugin only support read from Pulsar for now, write capability will be added later.
[CLONED]