Upload CI test results to S3 #23457
Merged
Upload CI test results to S3 #23457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've tested the xml to json conversion in a private Trino fork. That's how I came up with the length limits, since I already tried processing this with Trino. |
nineinchnick
force-pushed
the
test-results-to-s3
branch
from
5302c8c
to
ceb71ab
Compare
martint
reviewed
Sep 17, 2024
nineinchnick
force-pushed
the
test-results-to-s3
branch
from
ceb71ab
to
3945038
Compare
SemionPar
approved these changes
Sep 17, 2024
nineinchnick
force-pushed
the
test-results-to-s3
branch
2 times, most recently
from
cb83b42
to
711ee5e
Compare
nineinchnick
force-pushed
the
test-results-to-s3
branch
5 times, most recently
from
583bf11
to
cd224ab
Compare
|
It's ready to be merged, tested in my own fork: https://github.com/nineinchnick/trino/actions/runs/10920342447/job/30309980955 |
nineinchnick
force-pushed
the
test-results-to-s3
branch
from
cd224ab
to
54d4cbe
Compare
martint
reviewed
Sep 19, 2024
nineinchnick
force-pushed
the
test-results-to-s3
branch
from
54d4cbe
to
8f2368f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upload CI test results to S3, so we can create reports aggregating most commont failure causes in https://github.com/trinodb/reports.
This will require setting up new vars and secrets with the S3 bucket name and credentials. We can reuse the same bucket where we already copy GHA REST API data scraped in https://github.com/trinodb/reports.
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: