Running branch for Clickhouse pushdowns #23460
Open
+683
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 17, 2024
ssheikin
force-pushed
the
ssheikin/56/trino/clickhouse-pushdown
branch
from
bc141cf
to
4195edb
Compare
This was referenced Sep 20, 2024
ssheikin
force-pushed
the
ssheikin/56/trino/clickhouse-pushdown
branch
from
4195edb
to
2fcedb9
Compare
ssheikin
force-pushed
the
ssheikin/56/trino/clickhouse-pushdown
branch
3 times, most recently
from
344a9b5
to
c7c253b
Compare
ssheikin
force-pushed
the
ssheikin/56/trino/clickhouse-pushdown
branch
2 times, most recently
from
c3cd59d
to
bacc519
Compare
|
This is not ready to be merged, but as almost any PR it's ready for review 😉 |
ssheikin
force-pushed
the
ssheikin/56/trino/clickhouse-pushdown
branch
4 times, most recently
from
d726ebd
to
16d241f
Compare
ssheikin
force-pushed
the
ssheikin/56/trino/clickhouse-pushdown
branch
2 times, most recently
from
5ae0bf5
to
f2ba3ee
Compare
ssheikin
force-pushed
the
ssheikin/56/trino/clickhouse-pushdown
branch
5 times, most recently
from
79c478d
to
970eda6
Compare
This was referenced Oct 15, 2024
ssheikin
force-pushed
the
ssheikin/56/trino/clickhouse-pushdown
branch
2 times, most recently
from
680ac7f
to
aa0293c
Compare
The time zone is not stored in the rows of the table, but is stored in the column metadata. From ClickHouse documentation https://clickhouse.com/docs/en/sql-reference/data-types/datetime The point in time is saved as a Unix timestamp, regardless of the time zone or daylight saving time. The time zone affects how the values of the DateTime type values are displayed in text format and how the values specified as strings are parsed (‘2020-01-01 05:00:01’). Timezone agnostic Unix timestamp is stored in tables, and the timezone is used to transform it to text format or back during data import/export or to make calendar calculations on the values (example: toDate, toHour functions etc.). The time zone is not stored in the rows of the table (or in resultset), but is stored in the column metadata.
TIMESTAMP(p) TIMESTAMP(p) WITH TIME ZONE
ssheikin
force-pushed
the
ssheikin/56/trino/clickhouse-pushdown
branch
from
aa0293c
to
b1bc584
Compare
|
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
ssheikin
added
stale-ignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Smaller PRs will be chopped from this uber-PR.
TODO for varchars
Additional context and related issues
VARCHAR
PRs:
DATETIME
PRs:
ClickHouse docs:
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
(x) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: