Allow skipping over tasks in schedulingQueue if wait limits hit #23470
+455
−111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have a suspicion it could be written more simply |
losipiuk
force-pushed
the
lukaszos/allow-skipping-over-tasks-in-schedulingqueue-if-wait-limits-hit-f2b8e5
branch
2 times, most recently
from
45ae8f2
to
7f0ce9a
Compare
wendigo
reviewed
Sep 19, 2024
core/trino-main/src/main/java/io/trino/execution/scheduler/NodeSchedulerConfig.java
Outdated
Show resolved
Hide resolved
wendigo
reviewed
Sep 19, 2024
core/trino-main/src/main/java/io/trino/execution/scheduler/NodeSchedulerConfig.java
Outdated
Show resolved
Hide resolved
wendigo
reviewed
Sep 19, 2024
.../java/io/trino/execution/scheduler/faulttolerant/EventDrivenFaultTolerantQueryScheduler.java
Outdated
Show resolved
Hide resolved
wendigo
reviewed
Sep 19, 2024
| @@ -1913,6 +1905,14 @@ public Set<Map.Entry<ScheduledTask, PreSchedulingTaskContext>> listContextEntrie | |||
| return contexts.entrySet(); | |||
| } | |||
|
|
|||
| private long getWaitingForNodeTasksCount(TaskExecutionClass executionClass) | |||
There was a problem hiding this comment.
nit: getTasksWaitingForNodeCount
There was a problem hiding this comment.
It gets split into two methods later and Tasks is dropped from the name.
There was a problem hiding this comment.
Actually I did some renames. PTAL
wendigo
reviewed
Sep 19, 2024
.../java/io/trino/execution/scheduler/faulttolerant/EventDrivenFaultTolerantQueryScheduler.java
Outdated
Show resolved
Hide resolved
wendigo
reviewed
Sep 19, 2024
.../java/io/trino/execution/scheduler/faulttolerant/EventDrivenFaultTolerantQueryScheduler.java
Outdated
Show resolved
Hide resolved
wendigo
reviewed
Sep 19, 2024
.../java/io/trino/execution/scheduler/faulttolerant/EventDrivenFaultTolerantQueryScheduler.java
Outdated
Show resolved
Hide resolved
losipiuk
force-pushed
the
lukaszos/allow-skipping-over-tasks-in-schedulingqueue-if-wait-limits-hit-f2b8e5
branch
from
7f0ce9a
to
ba98dc3
Compare
wendigo
reviewed
Sep 19, 2024
...src/main/java/io/trino/execution/scheduler/faulttolerant/BinPackingNodeAllocatorService.java
Outdated
Show resolved
Hide resolved
wendigo
reviewed
Sep 19, 2024
...src/main/java/io/trino/execution/scheduler/faulttolerant/BinPackingNodeAllocatorService.java
Outdated
Show resolved
Hide resolved
wendigo
reviewed
Sep 19, 2024
...src/main/java/io/trino/execution/scheduler/faulttolerant/BinPackingNodeAllocatorService.java
Show resolved
Hide resolved
wendigo
approved these changes
Sep 19, 2024
If task suggests specific node for execution, but can be run elswhere, another node will be picked if designated node is out of resources for prolonged time.
If we are iterating over tasks in scheduling queue we may see that thera are already many tasks waiting for node lease for given requirements. In such case we are skipping a task and move to the next one, so one node does not block scheduling other tasks in queue which may have different node requirements. We are limiting how many tasks may be skipped to 20. This is to avoid pessimistic case that we are iterating over whole scheduling queue on each change in the cluster when it is highly utilized.
losipiuk
force-pushed
the
lukaszos/allow-skipping-over-tasks-in-schedulingqueue-if-wait-limits-hit-f2b8e5
branch
from
ba98dc3
to
f3d7900
Compare
|
Replaced with #23562 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If we are iterating over tasks in scheduling queue we may see that
there are already many tasks waiting for node lease for given requirements.
In such case we are skipping a task and move to the next one, so one node does not block
scheduling other tasks in queue which may have different node requirements.
We are limiting how many tasks may be skipped to 20. This is to avoid pessimistic case that we
are iterating over whole scheduling queue on each change in the cluster when it is highly utilized.
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: