Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple caching columns from caching table comments in glue for Iceberg #23483

Conversation

homar
Copy link
Member

@homar homar commented Sep 18, 2024

Description

Currently, when iceberg.glue.cache-table-metadata is set to true, columns and table comment are either stored together in Glue or none of them is stored.

The goal of this change is to prevent TrinoGlueCatalog from not caching table columns in glue when table comment is too long. It seems wrong that a decision to cache columns depends on the length of the table comment.

This commit changes that and makes storing them in Glue independent from each other.

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:
Decouple storing columns definition from storing table comments in glue

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Sep 18, 2024
@github-actions github-actions bot added the iceberg Iceberg connector label Sep 18, 2024
@homar homar marked this pull request as ready for review September 18, 2024 18:21
@homar homar force-pushed the homar/decouple_caching_comments_from_caching_columns branch 3 times, most recently from 8e48623 to 8ec11df Compare September 19, 2024 14:25
@ebyhr
Copy link
Member

ebyhr commented Sep 24, 2024

/test-with-secrets sha=8ec11dff4c3f73b736a6428937659c8fea7e8cfb

@ebyhr ebyhr self-requested a review September 24, 2024 00:10
Copy link

The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/11004474695

Copy link
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for property naming.

@homar homar force-pushed the homar/decouple_caching_comments_from_caching_columns branch 2 times, most recently from ab5c38c to d0f9ad0 Compare September 24, 2024 08:09
@homar homar requested a review from ebyhr September 24, 2024 08:22
@homar homar force-pushed the homar/decouple_caching_comments_from_caching_columns branch from d0f9ad0 to 42a96a5 Compare September 26, 2024 08:09
@homar homar requested a review from ebyhr September 26, 2024 10:39
@homar homar force-pushed the homar/decouple_caching_comments_from_caching_columns branch from 42a96a5 to abad951 Compare September 26, 2024 11:00
@homar homar requested a review from ebyhr September 27, 2024 07:29
@ebyhr ebyhr merged commit 3bd882f into trinodb:master Sep 27, 2024
40 of 41 checks passed
@github-actions github-actions bot added this to the 460 milestone Sep 27, 2024
@mosabua
Copy link
Member

mosabua commented Sep 27, 2024

What is the user impact of this change that we can add to the release notes. Currently the suggested entry is just talking about implementation details.

Something like

Ensure table comments are available from Glue even when columns are cached and comment text is long.

but less vague maybe?

Wdyt @martint @ebyhr @homar ?

@mosabua mosabua mentioned this pull request Sep 27, 2024
1 task
@homar
Copy link
Member Author

homar commented Sep 27, 2024

What is the user impact of this change that we can add to the release notes. Currently the suggested entry is just talking about implementation details.

Something like

Ensure table comments are available from Glue even when columns are cached and comment text is long.

but less vague maybe?

Wdyt @martint @ebyhr @homar ?

Something like:
Ensure table columns are cached in glue even when table comment is too long

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed iceberg Iceberg connector
Development

Successfully merging this pull request may close these issues.

3 participants