Improve spooling performance and memory accounting #23520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
force-pushed
the
serafin/memory-accounting-spooling
branch
from
3ebcf27
to
99db4cb
Compare
losipiuk
reviewed
Sep 23, 2024
core/trino-main/src/main/java/io/trino/operator/OutputSpoolingOperatorFactory.java
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/operator/OutputSpoolingOperatorFactory.java
Outdated
Show resolved
Hide resolved
testing/trino-testing/src/main/java/io/trino/testing/LocalSpoolingManager.java
Show resolved
Hide resolved
Both the encoder and spooling manager have streaming API. Buffering while encoding allocates a lot of memory that creates a pressure on the worker.
wendigo
force-pushed
the
serafin/memory-accounting-spooling
branch
from
99db4cb
to
dfe3a5e
Compare
losipiuk
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: