[Draft] Add support for TIMESTAMP and TIMESTAMP WITH TIME ZONE types in Exasol connector #26259

skyglass · 2025-07-22T09:51:36Z

Description

Added Exasol Trino connector support for Timestamp and Timestamp With Local Time Zone JDBC data types

Additional context and related issues

added correspondent tests for timestamp with precision data type
added correspondent tests for timestamp with local time zone with precision data type
implemented special addRoundTrip method with additional column expression parameter for the predicate to fix the test predicate assumption
all timestamp with timezone tests use input literal timestamp string, which is interpreted as a JVM timestamp string ("America/Bahia_Banderas") but expected literal strings are interpreted as UTC strings. Therefore the difference between these timestamps is 6 hours (with DST) or 5 (without DST); for some historical values, like 1970 for example, the difference can be 7, which is expected behaviour for timestamp with local time zone

Release notes

## Exasol Connect
* Add support for `timestamp` and `timestamp with time zone` types.

cla-bot · 2025-07-22T09:51:40Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2025-07-22T09:54:50Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2025-07-22T10:03:47Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2025-07-22T16:41:23Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2025-07-23T08:59:47Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2025-07-23T10:02:11Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2025-07-23T14:12:40Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

plugin/trino-exasol/src/main/java/io/trino/plugin/exasol/ExasolClient.java

testing/trino-product-tests/src/main/java/io/trino/tests/product/exasol/TestExasol.java

docs/src/main/sphinx/connector/exasol.md

plugin/trino-exasol/src/main/java/io/trino/plugin/exasol/ExasolClient.java

plugin/trino-exasol/src/test/java/io/trino/plugin/exasol/TestExasolTypeMapping.java

cla-bot · 2025-07-24T12:14:48Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2025-07-24T12:16:52Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2025-07-24T14:52:08Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2025-07-24T14:53:02Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2025-07-24T14:54:00Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2025-07-24T15:03:50Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2025-07-24T15:05:47Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

plugin/trino-exasol/src/test/java/io/trino/plugin/exasol/TestExasolTypeMapping.java

yelianevich · 2025-09-09T12:20:53Z

Hello everyone! Is anything missing on this PR? Looking forward to having it merged!

skyglass · 2025-09-10T18:21:23Z

Thank you very much for your reviews, @ebyhr , @chenjian2664 ! 👍

Any updates on the PR?
Please, let me know, if anything is missing or required.

plugin/trino-exasol/src/test/java/io/trino/plugin/exasol/TestExasolTypeMapping.java

docs/src/main/sphinx/connector/exasol.md

skyglass

Thank you very much for the review comments, @ebyhr , @chenjian2664 ! 👍
I have resolved the conversations and added code changes, based on the review comments.

plugin/trino-exasol/src/test/java/io/trino/plugin/exasol/TestExasolTypeMapping.java

plugin/trino-exasol/src/main/java/io/trino/plugin/exasol/ExasolClient.java

skyglass

I decided to move this PR to DRAFT and replace it with the new PR, with more simple, more efficient and less error-prone solution: #26633

Please, review the new PR, @ebyhr , @chenjian2664 ! 🙏

After reviewing the implementation, I believe the current approach - mapping Exasol TIMESTAMP WITH LOCAL TIME ZONE to Trino TIMESTAMP WITH TIME ZONE - adds unnecessary complexity and potential pitfalls.

Exasol TIMESTAMP WITH LOCAL TIME ZONE does not actually persist any time zone information. Apart from some minor edge cases, its semantics is very close to a plain Exasol TIMESTAMP.

Mapping to Trino TIMESTAMP WITH TIME ZONE requires hardcoding the JVM time zone, which introduces fragility. For example, values valid in the Exasol DB time zone but invalid in the JVM time zone (e.g., during DST gaps) may cause Trino to throw exceptions, potentially breaking queries.

A simpler mapping to Trino TIMESTAMP avoids these problems, is more efficient, and aligns better with how Exasol handles this type internally.

Given this, I created a new PR proposing the TIMESTAMP WITH LOCAL TIME ZONE → TIMESTAMP mapping, which I believe will result in a cleaner, simpler and more reliable solution: #26633

skyglass · 2025-09-15T13:21:22Z

Closed as outdated. See the new PR with improved solution for Exasol TIMESTAMP WITH LOCAL TIME ZONE: #26633

chenjian2664 · 2025-10-12T03:40:26Z

Does the timestamp part is the same as new pr #26259 ?

skyglass · 2025-10-13T07:53:35Z

Does the timestamp part is the same as new pr #26259 ?

The new PR is here: #26633

The main difference is that the new PR maps Exasol TIMESTAMP WITH LOCAL TIME ZONE to Trino TIMESTAMP.
The new PR is more simple.

This current PR was closed, because it was mapping Exasol TIMESTAMP WITH LOCAL TIME ZONE to Trino TIMESTAMP WITH TIME ZONE, which is not necessary, because Exasol TIMESTAMP WITH LOCAL TIME ZONE doesn't actually store the time zone information.

chenjian2664 · 2025-10-14T00:24:31Z

If it just about TIMESTAMP WITH LOCAL TIME ZONE, we could split to support TIMESTAMP first

skyglass · 2025-10-15T09:28:52Z

Does the timestamp part is the same as new pr #26259 ?

The new PR, which contains only TIMESTAMP changes, has been created:
#26963

github-actions bot added the exasol Exasol connector label Jul 22, 2025

skyglass force-pushed the feature/724_timestamp_data_types branch from 37a2fe5 to 78d1495 Compare July 22, 2025 10:03

skyglass mentioned this pull request Jul 22, 2025

[Closed Duplicate] Add support for TIMESTAMP and TIMESTAMP WITH TIME ZONE types in Exasol connector #26255

Closed

skyglass changed the title ~~Add support for TIMESTAMP and TIMESTAMP WITH TIME ZONE types in Exasol connector~~ [Closed Duplicate] Add support for TIMESTAMP and TIMESTAMP WITH TIME ZONE types in Exasol connector Jul 22, 2025

skyglass changed the title ~~[Closed Duplicate] Add support for TIMESTAMP and TIMESTAMP WITH TIME ZONE types in Exasol connector~~ Add support for TIMESTAMP and TIMESTAMP WITH TIME ZONE types in Exasol connector Jul 22, 2025

dekimir mentioned this pull request Jul 22, 2025

Test PR 2 dekimir/trino#2

Open

skyglass force-pushed the feature/724_timestamp_data_types branch from c950205 to d7ff56f Compare July 23, 2025 08:59

github-actions bot added the docs label Jul 23, 2025

skyglass force-pushed the feature/724_timestamp_data_types branch from ef6b95a to 07a421f Compare July 23, 2025 14:12

ebyhr reviewed Jul 23, 2025

View reviewed changes

skyglass force-pushed the feature/724_timestamp_data_types branch from 07a421f to 0d4b20a Compare July 24, 2025 12:14

skyglass force-pushed the feature/724_timestamp_data_types branch from 0d4b20a to bd554f9 Compare July 24, 2025 12:16

skyglass force-pushed the feature/724_timestamp_data_types branch from bd554f9 to 4ff3087 Compare July 24, 2025 14:52

skyglass force-pushed the feature/724_timestamp_data_types branch from 2a722d5 to 2c0b293 Compare July 24, 2025 15:05

chenjian2664 reviewed Jul 25, 2025

View reviewed changes

plugin/trino-exasol/src/test/java/io/trino/plugin/exasol/TestExasolTypeMapping.java Show resolved Hide resolved

skyglass force-pushed the feature/724_timestamp_data_types branch from 2c0b293 to cb525e5 Compare July 25, 2025 08:41

github-actions bot added the stale label Sep 8, 2025

github-actions bot removed the stale label Sep 9, 2025

skyglass force-pushed the feature/724_timestamp_data_types branch from 47da9cf to 3035c52 Compare September 10, 2025 18:17

skyglass force-pushed the feature/724_timestamp_data_types branch from 3035c52 to d94b914 Compare September 10, 2025 18:50

chenjian2664 reviewed Sep 11, 2025

View reviewed changes

skyglass force-pushed the feature/724_timestamp_data_types branch from d94b914 to fb10175 Compare September 11, 2025 09:36

ebyhr reviewed Sep 11, 2025

View reviewed changes

docs/src/main/sphinx/connector/exasol.md Outdated Show resolved Hide resolved

skyglass force-pushed the feature/724_timestamp_data_types branch from fb10175 to ab0858d Compare September 11, 2025 18:38

skyglass commented Sep 11, 2025

View reviewed changes

plugin/trino-exasol/src/test/java/io/trino/plugin/exasol/TestExasolTypeMapping.java Outdated Show resolved Hide resolved

plugin/trino-exasol/src/test/java/io/trino/plugin/exasol/TestExasolTypeMapping.java Outdated Show resolved Hide resolved

skyglass requested review from chenjian2664 and ebyhr September 11, 2025 18:41

skyglass force-pushed the feature/724_timestamp_data_types branch 3 times, most recently from 0270c0e to e1eaaeb Compare September 12, 2025 17:19

This comment was marked as duplicate.

Sign in to view

skyglass commented Sep 12, 2025

View reviewed changes

plugin/trino-exasol/src/main/java/io/trino/plugin/exasol/ExasolClient.java Show resolved Hide resolved

Add support for TIMESTAMP types in Exasol connector

1fda337

skyglass force-pushed the feature/724_timestamp_data_types branch from e1eaaeb to 1fda337 Compare September 12, 2025 19:42

skyglass changed the title ~~Add support for TIMESTAMP and TIMESTAMP WITH TIME ZONE types in Exasol connector~~ [Draft] Add support for TIMESTAMP and TIMESTAMP WITH TIME ZONE types in Exasol connector Sep 14, 2025

skyglass marked this pull request as draft September 14, 2025 18:32

skyglass mentioned this pull request Sep 14, 2025

[DRAFT] Add support for TIMESTAMP types in Exasol connector #26633

Closed

skyglass commented Sep 14, 2025

View reviewed changes

skyglass closed this Sep 15, 2025

[Draft] Add support for TIMESTAMP and TIMESTAMP WITH TIME ZONE types in Exasol connector #26259

[Draft] Add support for TIMESTAMP and TIMESTAMP WITH TIME ZONE types in Exasol connector #26259

Uh oh!

Conversation

skyglass commented Jul 22, 2025

Description

Additional context and related issues

Release notes

Uh oh!

cla-bot bot commented Jul 22, 2025

Uh oh!

cla-bot bot commented Jul 22, 2025

Uh oh!

cla-bot bot commented Jul 22, 2025

Uh oh!

cla-bot bot commented Jul 22, 2025

Uh oh!

cla-bot bot commented Jul 23, 2025

Uh oh!

cla-bot bot commented Jul 23, 2025

Uh oh!

cla-bot bot commented Jul 23, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cla-bot bot commented Jul 24, 2025

Uh oh!

cla-bot bot commented Jul 24, 2025

Uh oh!

cla-bot bot commented Jul 24, 2025

Uh oh!

cla-bot bot commented Jul 24, 2025

Uh oh!

cla-bot bot commented Jul 24, 2025

Uh oh!

cla-bot bot commented Jul 24, 2025

Uh oh!

cla-bot bot commented Jul 24, 2025

Uh oh!

Uh oh!

yelianevich commented Sep 9, 2025

Uh oh!

skyglass commented Sep 10, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

skyglass left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

This comment was marked as duplicate.

Uh oh!

Uh oh!

skyglass left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

skyglass commented Sep 15, 2025

Uh oh!

chenjian2664 commented Oct 12, 2025

Uh oh!

skyglass commented Oct 13, 2025

Uh oh!

chenjian2664 commented Oct 14, 2025

Uh oh!

skyglass commented Oct 15, 2025

Uh oh!

Reviewers

Assignees

skyglass left a comment •

edited

Loading