Remove deprecated gcs.use-access-token from gcs filesystem

[chenjian2664]

Description

Open at next version: 479

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:

## Section
* Remove deprecated `gcs.use-access-token` from gcs filesystem. ({issue}`issuenumber`)

Summary by Sourcery

Remove the deprecated gcs.use-access-token configuration option from the GCS filesystem by deleting its code, tests, and documentation references

Enhancements:

• Drop the isUseGcsAccessToken and setUseGcsAccessToken methods and related validation logic
• Remove backwards-compatibility tests and assertions for the deprecated access-token property

Documentation:

• Eliminate the gcs.use-access-token entry from the GCS filesystem documentation

Tests:

• Update TestGcsFileSystemConfig to remove deprecated property mappings and related test cases

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR eliminates the deprecated gcs.use-access-token option from the GCS filesystem by removing its configuration methods, validation logic, related test cases, and documentation entries.

Class diagram for updated GcsFileSystemConfig (removal of deprecated access token methods)

classDiagram
class GcsFileSystemConfig {
  - Optional<AuthType> authType
  - Optional<Boolean> useGcsAccessToken
  - String jsonKey
  - String jsonKeyFilePath
  + setAuthType(AuthType authType)
  + getJsonKey()
  + getJsonKeyFilePath()
  + isAuthMethodValid()
  - useGcsAccessToken (field, deprecated, removed)
  + isUseGcsAccessToken() (deprecated, removed)
  + setUseGcsAccessToken(boolean) (deprecated, removed)
  + isAuthTypeAndGcsAccessTokenConfigured() (validation, removed)
}

Loading

File-Level Changes

Change	Details	Files
Prune deprecated gcs.use-access-token handling from GcsFileSystemConfig	Delete @config setter and deprecated isUseGcsAccessToken() getter Remove backing Optional useGcsAccessToken field references Remove validation method isAuthTypeAndGcsAccessTokenConfigured()	lib/trino-filesystem-gcs/src/main/java/io/trino/filesystem/gcs/GcsFileSystemConfig.java
Clean up TestGcsFileSystemConfig to drop deprecated property tests	Remove backward compatibility test for gcs.use-access-token Drop related validation assertions Update assertFullMapping calls to exclude gcs.use-access-token key	lib/trino-filesystem-gcs/src/test/java/io/trino/filesystem/gcs/TestGcsFileSystemConfig.java
Remove deprecated property entry from documentation	Delete the gcs.use-access-token description and flag entry	docs/src/main/sphinx/object-storage/file-system-gcs.md

Possibly linked issues

• Document logging configuration options #477: The PR removes the gcs.use-access-token property, which is causing configuration errors in issue 477 after upgrade.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}