Skip to content

Add support for TIMESTAMP type in exasol connector #26963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+312 −0
Open

Add support for TIMESTAMP type in exasol connector #26963

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/src/main/sphinx/connector/exasol.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,9 @@ Trino data type mapping:
* - `DATE`
- `DATE`
-
* - `TIMESTAMP(n)`
- `TIMESTAMP(n)`
-
* - `HASHTYPE`
- `VARBINARY`
-
Expand Down
153 changes: 153 additions & 0 deletions plugin/trino-exasol/src/main/java/io/trino/plugin/exasol/ExasolClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@
import io.trino.plugin.jdbc.JdbcTypeHandle;
import io.trino.plugin.jdbc.LongReadFunction;
import io.trino.plugin.jdbc.LongWriteFunction;
import io.trino.plugin.jdbc.ObjectReadFunction;
import io.trino.plugin.jdbc.ObjectWriteFunction;
import io.trino.plugin.jdbc.QueryBuilder;
import io.trino.plugin.jdbc.SliceReadFunction;
import io.trino.plugin.jdbc.SliceWriteFunction;
Expand All @@ -43,12 +45,18 @@
import io.trino.spi.connector.ColumnPosition;
import io.trino.spi.connector.ConnectorSession;
import io.trino.spi.connector.ConnectorTableMetadata;
import io.trino.spi.type.LongTimestamp;
import io.trino.spi.type.TimestampType;
import io.trino.spi.type.Type;

import java.sql.Connection;
import java.sql.Date;
import java.sql.PreparedStatement;
import java.sql.SQLException;
import java.sql.Timestamp;
import java.sql.Types;
import java.time.LocalDate;
import java.time.LocalDateTime;
import java.util.HexFormat;
import java.util.List;
import java.util.Map;
Expand All @@ -57,20 +65,28 @@
import java.util.Set;
import java.util.function.BiFunction;

import static com.google.common.base.Preconditions.checkArgument;
import static io.trino.plugin.jdbc.PredicatePushdownController.FULL_PUSHDOWN;
import static io.trino.plugin.jdbc.StandardColumnMappings.bigintColumnMapping;
import static io.trino.plugin.jdbc.StandardColumnMappings.booleanColumnMapping;
import static io.trino.plugin.jdbc.StandardColumnMappings.decimalColumnMapping;
import static io.trino.plugin.jdbc.StandardColumnMappings.defaultCharColumnMapping;
import static io.trino.plugin.jdbc.StandardColumnMappings.defaultVarcharColumnMapping;
import static io.trino.plugin.jdbc.StandardColumnMappings.doubleColumnMapping;
import static io.trino.plugin.jdbc.StandardColumnMappings.fromLongTrinoTimestamp;
import static io.trino.plugin.jdbc.StandardColumnMappings.fromTrinoTimestamp;
import static io.trino.plugin.jdbc.StandardColumnMappings.integerColumnMapping;
import static io.trino.plugin.jdbc.StandardColumnMappings.smallintColumnMapping;
import static io.trino.plugin.jdbc.StandardColumnMappings.toLongTrinoTimestamp;
import static io.trino.plugin.jdbc.StandardColumnMappings.toTrinoTimestamp;
import static io.trino.plugin.jdbc.TypeHandlingJdbcSessionProperties.getUnsupportedTypeHandling;
import static io.trino.plugin.jdbc.UnsupportedTypeHandling.CONVERT_TO_VARCHAR;
import static io.trino.spi.StandardErrorCode.NOT_SUPPORTED;
import static io.trino.spi.connector.ConnectorMetadata.MODIFYING_ROWS_MESSAGE;
import static io.trino.spi.type.DateType.DATE;
import static io.trino.spi.type.DecimalType.createDecimalType;
import static io.trino.spi.type.TimestampType.MAX_SHORT_PRECISION;
import static io.trino.spi.type.TimestampType.createTimestampType;
import static io.trino.spi.type.VarbinaryType.VARBINARY;
import static java.lang.String.format;
import static java.util.Locale.ENGLISH;
Expand All @@ -84,6 +100,8 @@ public class ExasolClient
.add("SYS")
.build();

private static final int MAX_EXASOL_TIMESTAMP_PRECISION = 9;

@Inject
public ExasolClient(
BaseJdbcConfig config,
Expand Down Expand Up @@ -239,8 +257,12 @@ public Optional<ColumnMapping> toColumnMapping(ConnectorSession session, Connect
// String data is sorted by its binary representation.
// https://docs.exasol.com/db/latest/sql/select.htm#UsageNotes
return Optional.of(defaultVarcharColumnMapping(typeHandle.requiredColumnSize(), true));
// DATE and TIMESTAMP types are described here in more details:
// https://docs.exasol.com/db/latest/sql_references/data_types/datatypedetails.htm
case Types.DATE:
return Optional.of(dateColumnMapping());
case Types.TIMESTAMP:
return Optional.of(timestampColumnMapping(typeHandle));
}

if (getUnsupportedTypeHandling(session) == CONVERT_TO_VARCHAR) {
Expand Down Expand Up @@ -307,6 +329,137 @@ private static SliceWriteFunction hashTypeWriteFunction()
});
}

private static ColumnMapping timestampColumnMapping(JdbcTypeHandle typeHandle)
{
int timestampPrecision = typeHandle.requiredDecimalDigits();
TimestampType timestampType = createTimestampType(timestampPrecision);
if (timestampType.isShort()) {
return ColumnMapping.longMapping(
timestampType,
longTimestampReadFunction(timestampType),
longTimestampWriteFunction(timestampType),
FULL_PUSHDOWN);
}
return ColumnMapping.objectMapping(
timestampType,
objectTimestampReadFunction(timestampType),
objectTimestampWriteFunction(timestampType),
FULL_PUSHDOWN);
}

private static LongReadFunction longTimestampReadFunction(TimestampType timestampType)
{
verifyLongTimestampPrecision(timestampType);
return (resultSet, columnIndex) -> {
Timestamp timestamp = resultSet.getTimestamp(columnIndex);
return toTrinoTimestamp(timestampType, timestamp.toLocalDateTime());
};
}

private static LongWriteFunction longTimestampWriteFunction(TimestampType timestampType)
{
verifyLongTimestampPrecision(timestampType);
return new LongWriteFunction()
{
@Override
public String getBindExpression()
{
return getTimestampBindExpression(timestampType.getPrecision());
}

@Override
public void set(PreparedStatement statement, int index, long epochMicros)
throws SQLException
{
LocalDateTime localDateTime = fromTrinoTimestamp(epochMicros);
Timestamp timestampValue = Timestamp.valueOf(localDateTime);
statement.setTimestamp(index, timestampValue);
}

@Override
public void setNull(PreparedStatement statement, int index)
throws SQLException
{
statement.setNull(index, Types.TIMESTAMP);
}
};
}

private static ObjectReadFunction objectTimestampReadFunction(TimestampType timestampType)
{
verifyObjectTimestampPrecision(timestampType);
return ObjectReadFunction.of(
LongTimestamp.class,
(resultSet, columnIndex) -> {
Timestamp timestamp = resultSet.getTimestamp(columnIndex);
return toLongTrinoTimestamp(timestampType, timestamp.toLocalDateTime());
});
}

private static ObjectWriteFunction objectTimestampWriteFunction(TimestampType timestampType)
{
int precision = timestampType.getPrecision();
verifyObjectTimestampPrecision(timestampType);

return new ObjectWriteFunction() {
@Override
public Class<?> getJavaType()
{
return LongTimestamp.class;
}

@Override
public void set(PreparedStatement statement, int index, Object value)
throws SQLException
{
LocalDateTime localDateTime = fromLongTrinoTimestamp((LongTimestamp) value, precision);
Timestamp timestamp = Timestamp.valueOf(localDateTime);
statement.setTimestamp(index, timestamp);
}

@Override
public String getBindExpression()
{
return getTimestampBindExpression(timestampType.getPrecision());
}

@Override
public void setNull(PreparedStatement statement, int index)
throws SQLException
{
statement.setNull(index, Types.TIMESTAMP);
}
};
}

private static void verifyObjectTimestampPrecision(TimestampType timestampType)
{
int precision = timestampType.getPrecision();
checkArgument(precision > MAX_SHORT_PRECISION && precision <= MAX_EXASOL_TIMESTAMP_PRECISION,
"Precision is out of range: %s", precision);
}

private static void verifyLongTimestampPrecision(TimestampType timestampType)
{
int precision = timestampType.getPrecision();
checkArgument(precision >= 0 && precision <= MAX_SHORT_PRECISION,
"Precision is out of range: %s", precision);
}

/**
* Returns a {@code TO_TIMESTAMP} bind expression using the appropriate format model
* based on the given fractional seconds precision.
* See for more details: <a href="https://docs.exasol.com/db/latest/sql_references/formatmodels.htm">Date/time format models</a>
*/
private static String getTimestampBindExpression(int precision)
{
checkArgument(precision >= 0, "Precision is negative: %s", precision);
if (precision == 0) {
return "TO_TIMESTAMP(?, 'YYYY-MM-DD HH24:MI:SS')";
}
return format("TO_TIMESTAMP(?, 'YYYY-MM-DD HH24:MI:SS.FF%d')", precision);
}

@Override
public WriteMapping toWriteMapping(ConnectorSession session, Type type)
{
Expand Down
Loading