Skip to content

feat: Expose HTTP errors for non-JSON format response#874

Merged
yinggeh merged 1 commit into
mainfrom
yinggeh/tgh-60-http-errors-are-not-correctly-exposed-by-the-python-client
Jan 13, 2026
Merged

feat: Expose HTTP errors for non-JSON format response#874
yinggeh merged 1 commit into
mainfrom
yinggeh/tgh-60-http-errors-are-not-correctly-exposed-by-the-python-client

Conversation

@yinggeh

@yinggeh yinggeh commented Jan 12, 2026

Copy link
Copy Markdown
Contributor

What does the PR do?

When using the tritonclient.http or tritonclient.http.aio package to call a Triton server behind a gateway, and the gateway returns a non-200 status code with a message, the message might not be correctly raised to callers because it's not in JSON format.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • feat

Related PRs:

Where should the reviewer start?

Test plan:

  • CI Pipeline ID:

Caveats:

Background

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

@yinggeh yinggeh requested review from pskiran1 and whoisj January 12, 2026 21:26
@yinggeh yinggeh self-assigned this Jan 12, 2026
@yinggeh yinggeh added the enhancement New feature or request label Jan 12, 2026
@yinggeh yinggeh changed the title feat: Expose HTTP error for non-JSON format body feat: Expose HTTP error for non-JSON format response Jan 12, 2026
@yinggeh yinggeh merged commit 7ae0928 into main Jan 13, 2026
3 checks passed
@yinggeh yinggeh deleted the yinggeh/tgh-60-http-errors-are-not-correctly-exposed-by-the-python-client branch January 13, 2026 23:04
@yinggeh yinggeh changed the title feat: Expose HTTP error for non-JSON format response feat: Expose HTTP errors for non-JSON format response Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Development

Successfully merging this pull request may close these issues.

4 participants