Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed search options panel disappearance on startup #157

Merged
merged 1 commit into from
May 31, 2017
Merged

Fixed search options panel disappearance on startup #157

merged 1 commit into from
May 31, 2017

Conversation

notramo
Copy link
Contributor

@notramo notramo commented May 31, 2017

Trying to fix #156 and #131.

@trizen
Copy link
Owner

trizen commented May 31, 2017

Yeah, but this messes up the hpaned position in fullscreen mode. For example, when width=1920, and hpaned_position>1440.

Alternatively, we can try checking hpaned_position >= width - 200, if you can confirm that it works for you.

    # HPaned position correction
    if ($CONFIG{hpaned_position} >= ($mainw->get_size)[0] - 200) {
        $CONFIG{hpaned_position} = ($mainw->get_size)[0] * 0.75;
    }

@notramo
Copy link
Contributor Author

notramo commented May 31, 2017

($mainw->get_size)[0] - 200)
also works, but why isn't width * 0.75 good?

@trizen
Copy link
Owner

trizen commented May 31, 2017

In my case, in fullscreen mode, hpaned_position is 1676, which is more than width * 0.75, which is 1920*0.75 = 1440. So, checking for hpaned_position > width * 0.75 will evaluate to a true value and the hpaned_position will get set to 1440, which is not necessarily in this case.

Checking for hpaned_position >= width - 200 makes sure that the width of the search panel is not lower than 200 pixels, which should not happen under normal circumstances.

I'm still not sure what causes this annoying issue. Could it be a Gtk2 bug, or something?

@trizen trizen merged commit 041f1bc into trizen:master May 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No search panel shown
2 participants