Fix proxies to work consistently. #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it so the http_proxy and https_proxy environment variables are passed through to exec or system calls. This means any player that obeys these variables (mplayer, mpv, etc) will now use the proxy, as well as the actual searching and content downloads.
trizen
pushed a commit
that referenced
this pull request
May 30, 2015
Fix proxies to work consistently.
|
Thanks for the patch. Merged successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently proxies are only used for mplayer, mpv flat out rejects them and the
searches aren't proxied. These patches make everything go through proxies.