-
Notifications
You must be signed in to change notification settings - Fork 303
{agent, internal/tool, tool, docs}: configure ToolSet tool naming #2569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
2083966
tool: support optional original ToolSet names
Flash-LHR edd1157
llmagent: configure ToolSet names at registration
Flash-LHR 5db2594
docs: document ToolSet tool naming modes
Flash-LHR db060dd
docs: avoid invalid Chinese tool anchor
Flash-LHR dd787bc
docs: consolidate ToolSet naming guidance
Flash-LHR File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| // | ||
| // Tencent is pleased to support the open source community by making trpc-agent-go available. | ||
| // | ||
| // Copyright (C) 2025 Tencent. All rights reserved. | ||
| // | ||
| // trpc-agent-go is licensed under the Apache License Version 2.0. | ||
| // | ||
|
|
||
| package llmagent | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "strings" | ||
|
|
||
| "trpc.group/trpc-go/trpc-agent-go/tool" | ||
| ) | ||
|
|
||
| func validateAndNormalizeToolSetToolNameModes(options *Options) error { | ||
| if options == nil || len(options.toolSetToolNameModes) == 0 { | ||
| return nil | ||
| } | ||
| normalized := make(map[string]tool.ToolSetToolNameMode, len(options.toolSetToolNameModes)) | ||
| registeredNames := registeredToolSetNames(options) | ||
| for rawName, mode := range options.toolSetToolNameModes { | ||
| name := strings.TrimSpace(rawName) | ||
| if name == "" { | ||
| return fmt.Errorf("tool set name for tool name mode must not be empty") | ||
| } | ||
| switch mode { | ||
| case tool.ToolSetToolNameModeQualified, tool.ToolSetToolNameModeOriginal: | ||
| default: | ||
| return fmt.Errorf("unsupported tool name mode %d for tool set %q", mode, name) | ||
| } | ||
| if !registeredNames[name] { | ||
| return fmt.Errorf("tool set %q is not registered", name) | ||
| } | ||
| normalized[name] = mode | ||
| } | ||
| options.toolSetToolNameModes = normalized | ||
| return nil | ||
| } | ||
|
|
||
| func registeredToolSetNames(options *Options) map[string]bool { | ||
| names := make(map[string]bool) | ||
| if options == nil { | ||
| return names | ||
| } | ||
| for _, toolSets := range [][]tool.ToolSet{ | ||
| options.ToolSets, | ||
| options.activatableToolSets, | ||
| } { | ||
| for _, toolSet := range toolSets { | ||
| if toolSet == nil { | ||
| continue | ||
| } | ||
| if name := strings.TrimSpace(toolSet.Name()); name != "" { | ||
| names[name] = true | ||
| } | ||
| } | ||
| } | ||
| return names | ||
| } | ||
|
|
||
| func toolSetToolNameMode( | ||
| toolSetNameModes map[string]tool.ToolSetToolNameMode, | ||
| toolSet tool.ToolSet, | ||
| ) tool.ToolSetToolNameMode { | ||
| if toolSet == nil { | ||
| return tool.ToolSetToolNameModeQualified | ||
| } | ||
| name := strings.TrimSpace(toolSet.Name()) | ||
| if mode, ok := toolSetNameModes[name]; ok { | ||
| return mode | ||
| } | ||
| return tool.ToolSetToolNameModeQualified | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.