Skip to content

lib_pln: port queue/dedup improvements from benchmark variant #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rTreutlein wants to merge 2 commits into from
Closed

lib_pln: port queue/dedup improvements from benchmark variant #127

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f9b4c3
Merge pull request #131 from trueagi-io/feat/lib-remaining-changes-20…
patham9 Feb 20, 2026
80b842f
lib_pln: port queue and dedup improvements from benchmark variant
rTreutlein Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
105 changes: 74 additions & 31 deletions lib/lib_pln.metta
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
!(import! &self (library lib_import))
!(use-module! heaps)
!(import_prolog_function (superpose (empty_heap add_to_heap get_from_heap heap_size)))

(= (clamp $v $min $max)
(min $max (max $v $min)))

Expand Down Expand Up @@ -84,6 +88,19 @@
; (Unique $rest $Ret)
; (Unique $rest (TupleConcat ($x) $Ret))))))

;;Incremental tuple dedup helpers.
(= (PushUnique $L $x)
(if (ElementOf $x $L)
$L
(cons $x $L)))

(= (ConcatUnique $base $items)
(if (== $items ())
$base
(let* (($head (car-atom $items))
($tail (cdr-atom $items)))
(ConcatUnique (PushUnique $base $head) $tail))))

;; Consistency Conditions: PLN book "5.2.2.2 PLN Deduction and Second-Order Probability", page 74:

; borrowed from https://github.com/trueagi-io/hyperon-pln/blob/main/metta/pln/dependent-types/DeductionDTL.metta
Expand Down Expand Up @@ -377,9 +394,13 @@

;;Whether evidence was just counted once
(= (StampDisjoint $Ev1 $Ev2)
(== () (collapse (let* (($x (superpose $Ev1))
($y (superpose $Ev2)))
(case (== $x $y) ((True True)))))))
(if (== $Ev1 ())
True
(let* (($x (car-atom $Ev1))
($rest (cdr-atom $Ev1)))
(if (ElementOf $x $Ev2)
False
(StampDisjoint $rest $Ev2)))))

;;Concat stamp with sorting
(= (StampConcat $stamp $addition)
Expand All @@ -402,38 +423,47 @@
(= (PriorityRank (Sentence ($x (stv $f $c)) $Ev1)) $c)
(= (PriorityRank ()) -99999.0)

;;candidate elimination based on negated priority
(= (PriorityRankNeg (Sentence ($x (stv $f $c)) $Ev1)) (- 0.0 $c))
(= (PriorityRankNeg ()) -99999.0)
;;task heap helpers (highest confidence first, via negative key)
(= (TaskHeapPush $heap $item)
(let $prio (PriorityRank $item)
(add_to_heap $heap (- 0 $prio) $item)))

(= (TaskHeapFromTuple $tuple)
(foldl-atom $tuple (empty_heap) TaskHeapPush))

(= (HeapTakeItems $heap $n $acc)
(if (or (<= $n 0) (== (heap_size $heap) 0))
$acc
(let* (($rest (get_from_heap $heap $_priority $item)))
(HeapTakeItems $rest (- $n 1) (cons $item $acc)))))

;;Return limited-sized version of $L (bounded PQ functionality)
(= (LimitSize $L $size)
(if (< (TupleCount $L) $size)
(if (<= (TupleCount $L) $size)
$L
(let $lowestPriorityItem (BestCandidate PriorityRankNeg () $L)
(LimitSize (Without $L $lowestPriorityItem) $size))))
(HeapTakeItems (TaskHeapFromTuple $L) $size ())))

;;Priority-queue based task ranking deriver with belief buffer
(= (PLN.Derive $Tasks $Beliefs $steps $maxsteps $taskqueuesize $beliefqueuesize)
(if (or (> $steps $maxsteps) (== $Tasks ()))
($Tasks $Beliefs)
(let (Sentence $x $Ev1) (BestCandidate PriorityRank () $Tasks)
(let $derivations
(collapse (superpose ((let* (((Sentence $y $Ev2) (superpose $Beliefs))
($stamp (InsertionSort (TupleConcat $Ev1 $Ev2) ())))
(if (StampDisjoint $Ev1 $Ev2)
(case (superpose ((|- $x $y)
(|- $y $x)))
((($T $TV) (Sentence ($T $TV) $stamp))))
(empty)))
(case (|- $x) ((($T3 $TV3) (Sentence ($T3 $TV3) $Ev1)))))))
(let $temp (trace! (SELECTED $steps (Sentence $x $Ev1)) 42)
(PLN.Derive (LimitSize (Without (Unique (TupleConcat $Tasks $derivations) ()) (Sentence $x $Ev1)) $taskqueuesize)
(LimitSize (Unique (TupleConcat $Beliefs $derivations) ()) $beliefqueuesize)
(+ $steps 1)
$maxsteps
$taskqueuesize
$beliefqueuesize))))))
(let (Sentence $x $Ev1) (BestCandidate PriorityRank () $Tasks)
(let $derivations
(collapse (superpose ((let* (((Sentence $y $Ev2) (superpose $Beliefs)))
(if (StampDisjoint $Ev1 $Ev2)
(let $stamp (InsertionSort (TupleConcat $Ev1 $Ev2) ())
(superpose ((case (|- $x $y)
((($Txy $TVxy) (Sentence ($Txy $TVxy) $stamp))))
(case (|- $y $x)
((($Tyx $TVyx) (Sentence ($Tyx $TVyx) $stamp)))))))
(empty)))
(case (|- $x) ((($T3 $TV3) (Sentence ($T3 $TV3) $Ev1)))))))
(PLN.Derive (LimitSize (Without (ConcatUnique $Tasks $derivations) (Sentence $x $Ev1)) $taskqueuesize)
(LimitSize (ConcatUnique $Beliefs $derivations) $beliefqueuesize)
(+ $steps 1)
$maxsteps
$taskqueuesize
$beliefqueuesize)))))

(= (PLN.Derive $Tasks $Beliefs $maxsteps $taskqueuesize $beliefqueuesize)
(PLN.Derive $Tasks $Beliefs 1 $maxsteps $taskqueuesize $beliefqueuesize))
Expand All @@ -448,12 +478,26 @@
(= (ConfidenceRank ((stv $f $c) $Ev)) $c)
(= (ConfidenceRank ()) 0)

(= (ConfidenceHeapPush $heap $item)
(let $prio (ConfidenceRank $item)
(add_to_heap $heap (- 0 $prio) $item)))

(= (ConfidenceHeapFromTuple $tuple)
(foldl-atom $tuple (empty_heap) ConfidenceHeapPush))

(= (BestConfidenceCandidate $tuple)
(if (== $tuple ())
()
(let $_rest (get_from_heap (ConfidenceHeapFromTuple $tuple) $_priority $item)
$item)))

;;Pose a question of a certain term to the system on some knowledge base
(= (PLN.Query $Tasks $Beliefs $term $maxsteps $taskqueuesize $beliefqueuesize)
(BestCandidate ConfidenceRank () (collapse (let ($TasksRet $BeliefsRet) (PLN.Derive $Tasks $Beliefs $maxsteps $taskqueuesize $beliefqueuesize)
(case (superpose $BeliefsRet)
(((Sentence ($Term $TV) $Ev) (case (== $Term $term)
((True ($TV $Ev)))))))))))
(BestConfidenceCandidate
(collapse (let ($TasksRet $BeliefsRet) (PLN.Derive $Tasks $Beliefs $maxsteps $taskqueuesize $beliefqueuesize)
(case (superpose $BeliefsRet)
(((Sentence ($Term $TV) $Ev) (case (== $Term $term)
((True ($TV $Ev)))))))))))

(= (PLN.Query $kb $term $maxsteps $taskqueuesize $beliefqueuesize)
(PLN.Query $kb $kb $term $maxsteps $taskqueuesize $beliefqueuesize))
Expand All @@ -463,4 +507,3 @@

(= (PLN.Query $kb $term)
(PLN.Query $kb $term (PLN.Config.MaxSteps))) ;default steps bound