Expression -> Atom as the signal to not evaluate#144
Open
meditans wants to merge 2 commits intotrueagi-io:mainfrom
Open
Expression -> Atom as the signal to not evaluate#144meditans wants to merge 2 commits intotrueagi-io:mainfrom
Expression -> Atom as the signal to not evaluate#144meditans wants to merge 2 commits intotrueagi-io:mainfrom
Conversation
They were failing, and I think that's due to not importing foldall correctly, but my quick try with: ``` !(import! &self ../lib/lib_import.metta) !(use-module! aggregate) !(import_prolog_function foldall) ``` Didn't solve the problem. Since it's unrelated to the change I want to make, I'll leave them disabled for now.
In the MeTTa spec, Atom is the metatype that signals an argument should be passed unevaluated/raw for metaprogramming purposes. In the previous implementation this role was assigned to Expression. The actual change happens just in the `translate_args_by_type` function. The other changes are mechanical fixes to tests.
meditans
changed the title
Expression -> Atom as a type-guided signal for Expression -> Atom as the signal to not evaluate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft is meant as a starting point for a question on the topic we talked about yesterday: this function, which should be meant as identity over syntax
fails because a symbol is passed.
I wanted to see what broke if I tried to change it the way MeTTa does it, and there's not much to fix: a modification to
translate_args_by_typefunction suffices, the other changes are mechanical fixes the test suite.So now for the question: what else would be impacted by this? Am I missing something? You mentioned another solution:
What would be the upshot in this case?