Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-132530 / 25.04 / Fix API for rdma.get_card_choices #14955

Merged
merged 1 commit into from
Nov 14, 2024
Merged

NAS-132530 / 25.04 / Fix API for rdma.get_card_choices #14955

merged 1 commit into from
Nov 14, 2024

Conversation

bmeagherix
Copy link
Contributor

  1. Ensure we get all link choices.
  2. We are returning a list of cards

(Currently, this API will just be used for ixdiagnose.)

@bugclerk
Copy link
Contributor

Jira URL: https://ixsystems.atlassian.net/browse/NAS-132530

@bugclerk bugclerk changed the title Fix API for rdma.get_card_choices NAS-132530 / 25.04 / Fix API for rdma.get_card_choices Nov 14, 2024
@truenas truenas deleted a comment from bugclerk Nov 14, 2024
@bmeagherix bmeagherix merged commit eeece4a into master Nov 14, 2024
2 of 3 checks passed
@bmeagherix bmeagherix deleted the fix_rdma_get_card_choices branch November 14, 2024 22:20
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mgrimesix mgrimesix mgrimesix approved these changes

Assignees
No one assigned
Labels
jira-low no-time-tracked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bmeagherix @bugclerk @mgrimesix