Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132227 / 24.10.1 / Fix enable change in SMB table (by bvasilenko) #11008

Open
wants to merge 2 commits into
base: stable/electriceel
Choose a base branch
from

Conversation

bugclerk
Copy link
Contributor

@bugclerk bugclerk commented Nov 11, 2024

Testing:

On the Shares page

At the SMB block,

  1. User sets a share to Disabled state.

  2. User clicked View all to navigate to the distinguished SMB page.

  3. User sets this share to Enabled state.

  4. User goes back to Shares page, and observes the SMB block (and optionally refreshes the page).

  • Expected result: share is in Enabled state

Original PR: #11001
Jira URL: https://ixsystems.atlassian.net/browse/NAS-132227

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (stable/electriceel@6925da8). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...p/pages/sharing/smb/smb-list/smb-list.component.ts 62.50% 3 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             stable/electriceel   #11008   +/-   ##
=====================================================
  Coverage                      ?   79.97%           
=====================================================
  Files                         ?     1571           
  Lines                         ?    51430           
  Branches                      ?     5939           
=====================================================
  Hits                          ?    41132           
  Misses                        ?    10298           
  Partials                      ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bvasilenko bvasilenko marked this pull request as ready for review November 13, 2024 06:42
@bvasilenko bvasilenko requested a review from a team as a code owner November 13, 2024 06:42
@bvasilenko bvasilenko requested review from bvasilenko and removed request for a team November 13, 2024 06:42
Copy link
Contributor

@bvasilenko bvasilenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants