Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-131595 / 25.04 / Prepare redirect URL for IPv6 #11013

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bvasilenko
Copy link
Contributor

Testing

User configures an app to use IPv6 Address for it's web interface.

Steps to replicate

  1. When logging into the front-end by entering IPv4 address ( 127.0.0.1:4200 ) into the address bar,

  2. User configures some app to use IPv6 Address for it's web interface

  3. User logs out. And then logs in again, but by entering IPv6 address of the server into the address bar

  4. Go to Apps, choose this App, and click button to access app's web interface.

    Please also see video attachment in the ticket.

Expected Result

  • The Apps can be accessed using both Ipv4 and IPv6 URL's

@bvasilenko bvasilenko requested a review from a team as a code owner November 12, 2024 06:32
@bvasilenko bvasilenko requested review from AlexKarpov98 and removed request for a team November 12, 2024 06:32
@bvasilenko bvasilenko changed the title NAS-131595: Prepare redirect url for ipv6 NAS-131595: Prepare redirect URL for IPv6 Nov 12, 2024
@bugclerk bugclerk changed the title NAS-131595: Prepare redirect URL for IPv6 NAS-131595 / 25.04 / Prepare redirect URL for IPv6 Nov 12, 2024
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.04%. Comparing base (915b8f6) to head (ca84dd0).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11013   +/-   ##
=======================================
  Coverage   82.04%   82.04%           
=======================================
  Files        1616     1616           
  Lines       57015    57018    +3     
  Branches     5897     5898    +1     
=======================================
+ Hits        46778    46781    +3     
  Misses      10237    10237           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a similar fix I did here:
#10980

Probably should be fixed on MV side?

@undsoft, could you please check ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants