Skip to content
Open

Eli/wtf #9569

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/bazel.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,4 @@ jobs:
cli-version: 0.10.0-beta.3
bazel-bep-path: build_events.json
org-slug: trunk
token: ${{ secrets.TRUNK_TOKEN }}
token: ${{ secrets.TRUNK_TOKEN }}
82 changes: 41 additions & 41 deletions .github/workflows/csharp-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,53 +2,53 @@ name: C# Tests

on:
push:
branches: [ main ]
branches: [main]
paths:
- 'csharp/**'
- "csharp/**"
pull_request:
branches: [ main ]
branches: [main]
paths:
- 'csharp/**'
- "csharp/**"

jobs:
build:
runs-on: ubuntu-latest

steps:
- name: Checkout code
uses: actions/checkout@v4

- name: Setup .NET
uses: actions/setup-dotnet@v4
with:
dotnet-version: '8.0.x' # Updated to .NET 8

- name: Restore dependencies
run: dotnet restore csharp/ItsAlwaysSunnyOnEarth.sln

- name: Build
run: dotnet build csharp/ItsAlwaysSunnyOnEarth.sln --no-restore --configuration Release

- name: Test
run: dotnet test csharp/ItsAlwaysSunnyOnEarth.Tests/ItsAlwaysSunnyOnEarth.Tests.csproj --no-build --configuration Release --logger "junit;LogFilePath=test-results/csharp-junit.xml;MethodFormat=Class;FailureBodyFormat=Verbose"

- name: Upload results to Trunk
if: ${{ always() }}
uses: trunk-io/analytics-uploader@main
with:
cli-version: 0.10.0-beta.3
# Path to your test results.
# This path should match the LogFilePath used in the dotnet test command.
junit-paths: "**/csharp-junit.xml"
# Provide your Trunk organization slug.
org-slug: trunk
# Provide your Trunk API token as a GitHub secret.
token: ${{ secrets.TRUNK_TOKEN }}
continue-on-error: true

- name: Upload test results
if: always() # Always run this step to upload results
uses: actions/upload-artifact@v4
with:
name: csharp-test-results
path: 'test-results/csharp-junit.xml'
- name: Checkout code
uses: actions/checkout@v4

- name: Setup .NET
uses: actions/setup-dotnet@v4
with:
dotnet-version: "8.0.x" # Updated to .NET 8

- name: Restore dependencies
run: dotnet restore csharp/ItsAlwaysSunnyOnEarth.sln

- name: Build
run: dotnet build csharp/ItsAlwaysSunnyOnEarth.sln --no-restore --configuration Release

- name: Test
run: dotnet test csharp/ItsAlwaysSunnyOnEarth.Tests/ItsAlwaysSunnyOnEarth.Tests.csproj --no-build --configuration Release --logger "junit;LogFilePath=test-results/csharp-junit.xml;MethodFormat=Class;FailureBodyFormat=Verbose"

- name: Upload results to Trunk
if: ${{ always() }}
uses: trunk-io/analytics-uploader@main
with:
cli-version: 0.10.0-beta.3
# Path to your test results.
# This path should match the LogFilePath used in the dotnet test command.
junit-paths: "**/csharp-junit.xml"
# Provide your Trunk organization slug.
org-slug: trunk
# Provide your Trunk API token as a GitHub secret.
token: ${{ secrets.TRUNK_TOKEN }}
continue-on-error: true

- name: Upload test results
if: always() # Always run this step to upload results
uses: actions/upload-artifact@v4
with:
name: csharp-test-results
path: "test-results/csharp-junit.xml"
4 changes: 2 additions & 2 deletions .github/workflows/javascript-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,13 @@ jobs:
run: |
pnpm install
sudo npx playwright install-deps
npx playwright install
npx playwright install
- name: Run Mocha Tests
if: ${{ always() }}
run: |
npm run mocha-test || true
cat javascript/tests/mocha/mocha_test.xml
cat javascript/tests/mocha/mocha_test.xml
- name: Run Jest Tests
if: ${{ always() }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/pull_request_factory.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:

jobs:
merge-pr:
runs-on: [ubuntu-latest]
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v4
Expand All @@ -25,7 +25,7 @@ jobs:

create-pr:
needs: merge-pr
runs-on: [ubuntu-latest]
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v4
Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/retry-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
- uses: actions/checkout@v4

- name: set up python
uses: actions/setup-python@v4
uses: actions/setup-python@v5
with:
python-version: 3.x

Expand Down Expand Up @@ -65,8 +65,7 @@ jobs:
retention-days: 5

- name: trigger job re-run
if:
${{ failure() && steps.test.conclusion == 'failure' && fromJSON(github.run_attempt) < 5}}
if: ${{ failure() && steps.test.conclusion == 'failure' && fromJSON(github.run_attempt) < 5}}
env:
GH_REPO: ${{ github.repository }}
GH_TOKEN: ${{ github.token }}
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/ruby-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,11 @@ name: Ruby Tests
on:
schedule:
- cron: 0 */6 * * *
pull_request: {}
pull_request:
types: [opened, synchronize, reopened]
push:
branches: [ main, master ]
workflow_dispatch:

jobs:
test:
Expand Down
8 changes: 5 additions & 3 deletions .github/workflows/trunk_check.yaml
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
name: Trunk Check

on:
pull_request:
push: {}

permissions:
contents: read
# Required for Trunk to post annotations
checks: write
pull-requests: read

jobs:
trunk_check:
Expand All @@ -23,5 +24,6 @@ jobs:
cache: false
timeout-seconds: 1500 # 25 minutes in seconds
cat-trunk-debug-logs: true
github-token: ${{ github.token }}
debug: true
arguments: --log-level=debug
check-all-mode: "hold-the-line"
continue-on-error: true
2 changes: 1 addition & 1 deletion .trunk/trunk.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# To learn more about the format of this file, see https://docs.trunk.io/reference/trunk-yaml
version: 0.1
cli:
version: 1.24.1-beta.3
version: 1.24.1-beta.4
shell_hooks:
enforce: true

Expand Down
1 change: 1 addition & 0 deletions eslint.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ export default [
rules: {
semi: "error",
"prefer-const": "error",
"no-unused-vars": "error",
},
},
];
7 changes: 6 additions & 1 deletion javascript/src/season.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,12 @@ const Animal = {
};

class Season {
getCurrent() {
getOther() {
const unusedVariable = "This will trigger a linting error";
return "other";
}

getCurrent() {
return Animal.Rabbit;
}
}
Expand Down
Loading