Skip to content

Feature/parallel migrations #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Nagelfar
Copy link
Contributor

Using just IsolationLevel.Serializiable is not sufficient when running migrations in parallel.

  • For Postgres the simplest solution seems to be using and advisory transaction lock.
  • For SqlServer using Serializable is dangerous with regards to executed statements in the migration scripts
    Using with (SERIALIZABLE) and a retry mechanism worked in a stable way
  • Not sure if parallel migrations is relevant with SqlLite

@coveralls
Copy link

Pull Request Test Coverage Report for Build 31

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-3.5%) to 96.471%

Files with Coverage Reduction New Missed Lines %
C/projects/plainsql-migrations/PlainSql.Migrations/Migrator.cs 6 94.83%
Totals Coverage Status
Change from base Build 30: -3.5%
Covered Lines: 164
Relevant Lines: 170

💛 - Coveralls

@christophwalcher
Copy link
Contributor

@Nagelfar @danielweller-swp still relevant?

@Nagelfar
Copy link
Contributor Author

Nagelfar commented Jul 8, 2020

Relevant as in 'there is a problem with concurrent execution' - then I assume yes.
But not sure if it needs to be solved technical wise, or if updating the readme suffices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants