Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ecmascript): proxy set prototype of #515

Merged
merged 4 commits into from
Jan 7, 2025
Merged

feat(ecmascript): proxy set prototype of #515

merged 4 commits into from
Jan 7, 2025

Conversation

yossydev
Copy link
Contributor

@yossydev yossydev commented Jan 7, 2025

@yossydev yossydev requested a review from aapoalas January 7, 2025 12:31
aapoalas
aapoalas approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@aapoalas aapoalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for all this Proxy work! If I'm not badly mistaken, we're pretty close to having all the methods implemented now right?

@aapoalas aapoalas merged commit fd130c4 into trynova:main Jan 7, 2025
1 check passed
@yossydev
Copy link
Contributor Author

yossydev commented Jan 7, 2025

LGTM, thank you for all this Proxy work! If I'm not badly mistaken, we're pretty close to having all the methods implemented now right?

Yes, it will be done by the end of the week!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aapoalas aapoalas aapoalas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yossydev @aapoalas