Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ecmascript): %TypedArray%.prototype.findLastIndex #590

Merged
merged 3 commits into from
Mar 10, 2025

Conversation

yossydev
Copy link
Contributor

You mentioned it could be optimized before, but I just went ahead and implemented it for now.

ref: #145
doc: https://tc39.es/ecma262/multipage/indexed-collections.html#sec-%typedarray%.prototype.findlastindex

Copy link
Member

@aapoalas aapoalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice <3

The optimisation would be making a find_via_predicate version here in typed_array_intrinsic_object.rs that is generic on T: Viewable ... maybe. Not sure if it would actually give a meaningful performance increase now that I think about it.

aapoalas
aapoalas previously approved these changes Mar 10, 2025
@aapoalas aapoalas force-pushed the feat/typedarray-find-last-index branch from 61d00bd to a13f71b Compare March 10, 2025 21:17
@aapoalas aapoalas merged commit 48ea659 into trynova:main Mar 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants