Skip to content

Conversation

@aguscas
Copy link
Collaborator

@aguscas aguscas commented Feb 23, 2024

The default value for draw_labels was not the same in draw_boxes and draw_points. For consistency, I think it would be better to have the same default value

@javiber
Copy link
Collaborator

javiber commented Feb 26, 2024

Does this affect any demo? maybe the videos look different now if they were relying on the default argument

@aguscas
Copy link
Collaborator Author

aguscas commented Feb 26, 2024

Does this affect any demo? maybe the videos look different now if they were relying on the default argument

I would argue that doing this make the demos even more consistent with the videos we show in their README. As you can see in the yolov7 demo when we use this function we use the default value, but in the video in the README there is no label. That is because the video was generated with the old drawing functions, and when we updated the drawing functions we forgot to pass the argument to not draw the labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants