Use in process java compilation unless jdk is explicitly set by the d… #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eveloper This PR updates KCT to use in process compilation unless the developer explicitly provides a jdkHome that does not match the java home of the current process. In most cases, it won't be provided and because we have a default, current implementation makes KCT spin off another process to compile java sources, causing a significant compilation time penalty. tschuchortdev#113 (comment) With this change, KCT won't create another process unless jdkHome is set to a value that does not match the jdk home inherited from the current process. Issue: tschuchortdev#113 Test: As this is a bit difficult to test, I've added test that will check the logs ¯\_(ツ)_/¯
yigit
force-pushed
the
use-in-process-compilation-when-jdk-is-the-same
branch
from
6cf8d26 to
54e6cec
Compare
|
@tschuchortdev would it be possible to get a release after this is merged ? |
tschuchortdev
approved these changes
Feb 22, 2021
core/src/test/kotlin/com/tschuchort/compiletesting/KotlinCompilationTests.kt
Outdated
Show resolved
Hide resolved
|
I will make a new release after this is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates KCT to use in process compilation unless the developer
explicitly provides a jdkHome that does not match the java home of the
current process.
In most cases, it won't be provided and because we have a default,
current implementation makes KCT spin off another process to compile java
sources, causing a significant compilation time penalty.
#113 (comment)
With this change, KCT won't create another process unless jdkHome is
set to a value that does not match the jdk home inherited from the
current process.
Issue: #113
Test: As this is a bit difficult to test, I've added test that will
check the logs ¯_(ツ)_/¯