Add schWidth prop with a test #87
Conversation
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
I dont see how this code could work, you should show it worked in the test. Also there are a lot of unnecessary changes or changes to the API (schWidth should be top level, not inside of portArrangement)
There was no math to compute the width as far as i could see so i dont know if this would work? Maybe show in the test that it worked
| schPortArrangement: { | ||
| leftSize: 4, | ||
| rightSize: 4, | ||
| schWidth: 2, |
There was a problem hiding this comment.
Isnt this supposed the be a top level prop? Why is it inside portArrangement?
There was a problem hiding this comment.
this is a pretty good PR, but i think it would be better to modify
getPortArrangementSizeto support taking aschWidthprop, transforming things can make the code more complicated over time since it's not clear where the original width is.
I thought you meant that I needed to add it there.
There was a problem hiding this comment.
Here is the bug with schWidth set to 2
There was a problem hiding this comment.
Yea it looks broken, the ports should be outside of the box
There was a problem hiding this comment.
They are like glued - the box changes its width, but they do not move
| ) | ||
| .build() | ||
|
|
||
| await logSoup(soup) |
There was a problem hiding this comment.
Add a test for the schWidth
|
@seveibar from what I see here the only place that will get the
|
Anshgrover23
left a comment
Anshgrover23
left a comment
There was a problem hiding this comment.
@Slaviiiii checks are failing. kindly run npm run format
No description provided.