Skip to content

fix: guard missing jlc search results #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: guard missing jlc search results #339

wants to merge 1 commit into from

Conversation

seveibar
Copy link
Contributor

Summary

  • prevent TypeError in tsci search when JLC search returns no components
  • guard import command against missing JLC components results

Testing

  • bunx tsc --noEmit
  • bun test tests/cli/search
  • bun test tests/cli/import

https://chatgpt.com/codex/tasks/task_b_68c364c3fcd8832ea7ace50c5021be8c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imrishabh18 imrishabh18 Awaiting requested review from imrishabh18 imrishabh18 is a code owner

@ArnavK-09 ArnavK-09 Awaiting requested review from ArnavK-09 ArnavK-09 is a code owner

Assignees
No one assigned
Labels
codex
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@seveibar