Merge pull request #588 from tscircuit/fix/schematic-props

fix: schematic x and y props using parsed value in mm

lib/components/base-components/PrimitiveComponent.ts

@@ -280,7 +280,8 @@ export abstract class PrimitiveComponent<
    * schematic components
    */
   computeSchematicPropsTransform(): Matrix {
-    return compose(translate(this.props.schX ?? 0, this.props.schY ?? 0))
+    const { _parsedProps: props } = this
+    return compose(translate(props.schX ?? 0, props.schY ?? 0))
   }
 
   /**

tests/repros/repo8-resistor-schX.test.tsx

@@ -0,0 +1,62 @@
+import { test, expect } from "bun:test"
+import { getTestFixture } from "tests/fixtures/get-test-fixture"
+
+test("board with resistor being passed schX and pcbX in mm", () => {
+  const { circuit } = getTestFixture()
+
+  circuit.add(
+    <board width="10mm" height="10mm">
+      <resistor
+        resistance="1k"
+        footprint="0402"
+        name="R1"
+        schX="2mm"
+        pcbX="-2mm"
+      />
+    </board>,
+  )
+
+  circuit.render()
+
+  expect(circuit.db.schematic_component.list()).toMatchInlineSnapshot(`
+    [
+      {
+        "center": {
+          "x": 2,
+          "y": 0,
+        },
+        "rotation": 0,
+        "schematic_component_id": "schematic_component_0",
+        "size": {
+          "height": 0.388910699999999,
+          "width": 1.0583332999999997,
+        },
+        "source_component_id": "source_component_0",
+        "symbol_display_value": "1kΩ",
+        "symbol_name": "boxresistor_right",
+        "type": "schematic_component",
+      },
+    ]
+  `)
+
+  expect(circuit.db.pcb_component.list()).toMatchInlineSnapshot(`
+    [
+      {
+        "center": {
+          "x": -2,
+          "y": 0,
+        },
+        "height": 0.6000000000000001,
+        "layer": "top",
+        "pcb_component_id": "pcb_component_0",
+        "rotation": 0,
+        "source_component_id": "source_component_0",
+        "subcircuit_id": "subcircuit_source_group_0",
+        "type": "pcb_component",
+        "width": 1.5999999999999999,
+      },
+    ]
+  `)
+
+  expect(circuit).toMatchSchematicSnapshot(import.meta.path)
+})