Skip to content

Integrate the drc check checkEachPcbPortConnected #1157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 18, 2025
Merged

Conversation

imrishabh18
Copy link
Member

@imrishabh18 imrishabh18 commented Aug 14, 2025

No description provided.

Copy link

vercel bot commented Aug 14, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
tscircuit-core-benchmarks Ready Ready Preview Comment Aug 17, 2025 2:20pm

Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests you modified to snapshot errors are demonstrating the check is not working properly and throwing errors even though there is nothing to connect

Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!!

@imrishabh18 imrishabh18 merged commit 15ce639 into main Aug 18, 2025
11 checks passed
@imrishabh18 imrishabh18 deleted the integrate-check branch August 18, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants