Skip to content
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
f81b8b0
Fix schPinSpacing changing the width of the schematic box
RaghavArora14 Oct 24, 2025
e1e6fc4
Delete PR-DESCRIPTION.md
RaghavArora14 Oct 24, 2025
186d155
Delete reproduce-issue.md
RaghavArora14 Oct 24, 2025
551b80d
Remove comments on padding logic for dimensions
RaghavArora14 Oct 24, 2025
d5d3338
Simplify fix and combine tests into single file
RaghavArora14 Oct 24, 2025
5a3af2d
Move padding constant to root scope with descriptive name
RaghavArora14 Oct 24, 2025
c336810
Fix schPinSpacing changing the width of the schematic box
RaghavArora14 Oct 24, 2025
7b1179e
Rename test to repro68-schpinspacing-width
RaghavArora14 Oct 25, 2025
b8e82b6
Add minimum width for chips with left/right pin labels
RaghavArora14 Oct 26, 2025
e76cab9
Format code and rename schWidth to resolvedSchWidth
RaghavArora14 Oct 26, 2025
38ce274
Convert portHints to pinLabels for width calculation
RaghavArora14 Oct 26, 2025
fcb9a29
Format Fix
RaghavArora14 Oct 26, 2025
668fb8a
Fix portHints extraction to access footprint children directly
RaghavArora14 Oct 26, 2025
f356196
Fix portHints extraction to access footprint children directly
RaghavArora14 Oct 26, 2025
01d50a7
Access Footprint from children instead of props
RaghavArora14 Oct 26, 2025
c6f94c4
Update snapshot for chip-layer-flip test
RaghavArora14 Oct 26, 2025
3b93c88
refactor: use selectAll('port') and getNameAndAliases() for pin labels
RaghavArora14 Oct 27, 2025
bf92957
test: update snapshots for tests with numeric portHints
RaghavArora14 Oct 27, 2025
f56aee4
refactor: remove redundant pinLabels merging logic
RaghavArora14 Oct 27, 2025
d128a8f
bun format
RaghavArora14 Oct 27, 2025
232618b
fix: keep props.pinLabels for label-to-pin-number mapping and update …
RaghavArora14 Oct 27, 2025
55c6eaa
refactor: extract _getBestDisplayPinLabel() to consolidate pin label …
RaghavArora14 Oct 27, 2025
2ee7292
fix: add type cast for Port in _getPinLabelsFromPorts
RaghavArora14 Oct 27, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions lib/utils/schematic/getAllDimensionsForSchematicBox.ts
Original file line number Diff line number Diff line change
Expand Up @@ -346,9 +346,10 @@ export const getAllDimensionsForSchematicBox = (
// Use lengths to determine schWidth and schHeight
let schWidth = params.schWidth
if (schWidth === undefined) {
const MIN_PADDING = 0.4
schWidth = Math.max(
sideLengths.top + params.schPinSpacing * 2,
sideLengths.bottom + params.schPinSpacing * 2,
sideLengths.top + MIN_PADDING,
sideLengths.bottom + MIN_PADDING,
)

const labelWidth = params.pinLabels
Expand All @@ -366,9 +367,10 @@ export const getAllDimensionsForSchematicBox = (

let schHeight = params.schHeight
if (!schHeight) {
const MIN_PADDING = 0.4
schHeight = Math.max(
sideLengths.left + params.schPinSpacing * 2,
sideLengths.right + params.schPinSpacing * 2,
sideLengths.left + MIN_PADDING,
sideLengths.right + MIN_PADDING,
)
}

Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading