Fix/sch pin spacing box width #1580
Open
+62
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Aqil-Ahmad
force-pushed
the
fix/schPinSpacing-box-width
branch
from
4d445ce to
72b1220
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
1
to
52
| import { test, expect } from "bun:test" | ||
| import { getAllDimensionsForSchematicBox } from "lib/utils/schematic/getAllDimensionsForSchematicBox" | ||
|
|
||
| test("schPinSpacing should not change the width of the schematic box", () => { | ||
| // Test with different pin spacings but same port arrangement | ||
| const baseParams = { | ||
| schPortArrangement: { | ||
| leftSize: 2, | ||
| rightSize: 2, | ||
| topSize: 2, | ||
| bottomSize: 2, | ||
| }, | ||
| pinCount: 8, | ||
| numericSchPinStyle: {}, | ||
| } | ||
|
|
||
| // Get dimensions with default spacing (0.2) | ||
| const dims1 = getAllDimensionsForSchematicBox({ | ||
| ...baseParams, | ||
| schPinSpacing: 0.2, | ||
| }) | ||
| const size1 = dims1.getSize() | ||
|
|
||
| // Get dimensions with larger spacing (0.5) | ||
| const dims2 = getAllDimensionsForSchematicBox({ | ||
| ...baseParams, | ||
| schPinSpacing: 0.5, | ||
| }) | ||
| const size2 = dims2.getSize() | ||
|
|
||
| // Get dimensions with even larger spacing (1.0) | ||
| const dims3 = getAllDimensionsForSchematicBox({ | ||
| ...baseParams, | ||
| schPinSpacing: 1.0, | ||
| }) | ||
| const size3 = dims3.getSize() | ||
|
|
||
| console.log("Width with spacing 0.2:", size1.width) | ||
| console.log("Width with spacing 0.5:", size2.width) | ||
| console.log("Width with spacing 1.0:", size3.width) | ||
| console.log("Height with spacing 0.2:", size1.height) | ||
| console.log("Height with spacing 0.5:", size2.height) | ||
| console.log("Height with spacing 1.0:", size3.height) | ||
|
|
||
| // Width should remain constant regardless of pin spacing | ||
| expect(size1.width).toBe(size2.width) | ||
| expect(size2.width).toBe(size3.width) | ||
|
|
||
| // Height is expected to change with spacing (left/right pins) | ||
| expect(size1.height).toBeLessThan(size2.height) | ||
| expect(size2.height).toBeLessThan(size3.height) | ||
| }) |
There was a problem hiding this comment.
The test file name 'repro-schPinSpacing-changes-box-width.test.tsx' is inconsistent with the project's naming conventions. The file contains only one test function, but uses a very long descriptive name instead of following the kebab-case pattern or matching export names as specified in the file naming rule. Consider renaming to a shorter, more consistent name like 'sch-pin-spacing-box-width.test.tsx' or similar kebab-case format that aligns with the project's naming conventions.
Spotted by Graphite Agent (based on custom rule: Custom rule)
Is this helpful? React 👍 or 👎 to let us know.
2 tasks
Aqil-Ahmad
force-pushed
the
fix/schPinSpacing-box-width
branch
from
72b1220 to
67d7a04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #1576
/claim #1576
before:
after:
