Fix silkscreen paths causing extra pins in schematic view #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to tscircuit#308 Add method to prevent silkscreen paths from being interpreted as pins in schematic view. * **SilkscreenPath.ts** - Add `doInitialSchematicComponentRender` method to `SilkscreenPath` class to prevent silkscreen paths from being interpreted as pins in the schematic view. * **silkscreenpath.test.tsx** - Add test case to verify that silkscreen paths are not interpreted as pins in the schematic view.
seveibar
reviewed
Nov 15, 2024
|
|
||
| const schematicPins = project.db.schematic_pin.list() | ||
|
|
||
| expect(schematicPins.length).toBe(0) |
There was a problem hiding this comment.
hmm actually the repro calls for a <chip />
seveibar
requested changes
Nov 15, 2024
|
The fix is probably in this code
but you should get a good repro first |
* Add test case for rendering SilkscreenPath on different layers * Add test case for rendering SilkscreenPath with different routes
…chematic view * Add test case to check that the chip footprint does not cause extra pins to appear in the schematic view * Cover various chip footprints and configurations in the test case * Ensure the test case includes a silkscreen path to verify it is not interpreted as a pin
…h` class to prevent fabrication note paths from being interpreted as pins in the schematic view * Add a new method `doInitialSchematicComponentRender` to the `FabricationNotePath` class * Leave the method intentionally blank to prevent fabrication note paths from being interpreted as pins in the schematic view
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #308
Add method to prevent silkscreen paths from being interpreted as pins in schematic view.
doInitialSchematicComponentRendermethod toSilkscreenPathclass to prevent silkscreen paths from being interpreted as pins in the schematic view.