Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed non-port elements being added as ports for custom footprints #315

Merged
merged 3 commits into from
Nov 16, 2024
Merged

fixed non-port elements being added as ports for custom footprints #315

merged 3 commits into from
Nov 16, 2024

Conversation

ShiboSoftwareDev
Copy link
Contributor

@ShiboSoftwareDev ShiboSoftwareDev commented Nov 16, 2024 •
edited
Loading

/claim #302
/closes #302
/claim #308
/closes #308

the silkscreen element used to be seen as a fifth port in the test

@algora-pbc algora-pbc bot mentioned this pull request Nov 16, 2024
Closed
@ShiboSoftwareDev
Copy link
Contributor Author

looks like you can't claim two bounties in one pr

@seveibar seveibar merged commit 0ecd29e into tscircuit:main Nov 16, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seveibar seveibar seveibar approved these changes

@imrishabh18 imrishabh18 Awaiting requested review from imrishabh18

Assignees
No one assigned
Labels
🙋 Bounty claim
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Silkscreen Paths cause extra pins in schematic view Custom Footprints sometimes have an extra schematic pin
2 participants
@ShiboSoftwareDev @seveibar