Implement pcbOffsetX and pcbOffsetY in <board /> #485
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size ReportBundle Size
Install Size
Full Howfat Output (PR Branch) |
Size ReportBundle Size
Install Size
Full Howfat Output (PR Branch) |
seveibar
reviewed
Jan 6, 2025
Comment on lines
345
to
+347
| outline?: Point[] | ||
| } | ||
| type PcbBoardWithOffsets = PcbBoard & { |
There was a problem hiding this comment.
Suggested change
| outline?: Point[] | |
| } | |
| type PcbBoardWithOffsets = PcbBoard & { | |
| outline?: Point[] |
btw this file is supposed to be replaced with tscircuit plop (npm install -g @tscircuit/plop then run plop)
seveibar
reviewed
Jan 6, 2025
| > & { | ||
| pcbOffsetX: number | ||
| pcbOffsetY: number | ||
| } |
There was a problem hiding this comment.
nooooo no other files do this, why would you do this pattern?
seveibar
requested changes
Jan 6, 2025
There was a problem hiding this comment.
no test, and a bunch of irrelevant changes,
@techmannih read over your work, make sure there aren't irrelevant changes, check the patterns and always start by writing a test that makes sure YOU understand what you're supposed to be implementing
with no test it's not worth requesting a review. I've seen a couple of these at this point from you and it takes up my time, this one is really really bad though. Why wouldn't you write a test? Write a snapshot PCB test, that will demonstrate to you that it doesn't work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #484
/claim #484