patch: improve error message #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a react component inside the jsx
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Anshgrover23
requested changes
Feb 9, 2025
BEFORE
AFTER
|
seveibar
reviewed
Feb 9, 2025
| @@ -466,6 +466,11 @@ export abstract class PrimitiveComponent< | |||
| } | |||
|
|
|||
| add(component: PrimitiveComponent) { | |||
| if (!component.onAddToParent) { | |||
| throw new Error( | |||
| "Invalid JSX Element: Expected a React component but received a non-component value. Ensure you are using a valid component (function or class) and that it's properly imported.", | |||
There was a problem hiding this comment.
can you attempt to stringify it to make the error message even better.
Also no need for the latter half
Suggested change
| "Invalid JSX Element: Expected a React component but received a non-component value. Ensure you are using a valid component (function or class) and that it's properly imported.", | |
| "Invalid JSX Element: Expected a React component but received "...". |
seveibar
reviewed
Feb 9, 2025
seveibar
requested changes
Feb 9, 2025
| </board>, | ||
| ) | ||
| }).toThrowError("Invalid JSX Element") | ||
| }) |
There was a problem hiding this comment.
make sure to test with new ClassName() because i think JSON.stringify could error
There was a problem hiding this comment.
or you could put in a function or something
seveibar
approved these changes
Feb 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/claim #556
Before
After