Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hull-render issue #8

Merged
merged 2 commits into from
Feb 3, 2025
Merged

fix: hull-render issue #8

merged 2 commits into from
Feb 3, 2025

Conversation

rohittcodes
Copy link
Contributor

@algora-pbc algora-pbc bot mentioned this pull request Feb 3, 2025
Closed
imrishabh18
imrishabh18 reviewed Feb 3, 2025
View reviewed changes
Copy link
Member

@imrishabh18 imrishabh18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Can you add the workflow file to run the test to make sure everything passes please?

Take reference from the other repo's

seveibar
seveibar approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow that previous code was JUNK

/tip $2

@seveibar seveibar merged commit d23acce into tscircuit:main Feb 3, 2025
1 check passed
@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Feb 3, 2025

🎉🎈 @rohittcodes has been awarded $2! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imrishabh18 imrishabh18 imrishabh18 left review comments

@seveibar seveibar seveibar approved these changes

Assignees
No one assigned
Labels
🙋 Bounty claim 💰 Rewarded
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Motor Driver Pin Header Rendering issue "Typeerror...."
3 participants
@rohittcodes @seveibar @imrishabh18