add externallyConnectedPins prop in ChipProps #149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anshgrover23
approved these changes
Jan 24, 2025
imrishabh18
requested changes
Jan 24, 2025
There was a problem hiding this comment.
Just making sure we are following the pattern which is being used in the codebase, cause I don't see we use tuple.
I think we should allow number as well to be passed in the prop pin number
cc: @seveibar
| @@ -24,6 +24,7 @@ export interface ChipProps extends CommonComponentProps { | |||
| schWidth?: Distance | |||
| schHeight?: Distance | |||
| noSchematicRepresentation?: boolean | |||
| externallyConnectedPins?: [string, string][] | |||
There was a problem hiding this comment.
Suggested change
| externallyConnectedPins?: [string, string][] | |
| externallyConnectedPins?: Array<Array<string | number>> |
Comment on lines
+56
to
+58
| externallyConnectedPins: z | ||
| .array(z.tuple([z.string(), z.string()])) | ||
| .optional(), |
There was a problem hiding this comment.
Suggested change
| externallyConnectedPins: z | |
| .array(z.tuple([z.string(), z.string()])) | |
| .optional(), | |
| externallyConnectedPins: z | |
| .array(z.array(z.union([z.string(), z.number()]))) | |
| .optional(), |
|
Ok this is done ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to introduce
externallyConnectedPinsfor moving forward with tscircuit/core#548