Snapshot test #42
Merged
Snapshot test #42
+314
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
seveibar
reviewed
Dec 23, 2025
Contributor
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
Can you combine all the layers into a single svg with each layer labeled in a grid?
use stackSvgs or verticallyStackGraphicsObjects
looking at different files is too difficult, not useful
Contributor
|
@0hmX actually not even a grid, this is perfect for github diffs 
|
Contributor
Author
|
@seveibar check out the new snapshot |
imrishabh18
reviewed
Dec 24, 2025
seveibar
approved these changes
Dec 25, 2025
Contributor
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
The svg is too wide, it should only be as wide as the content to make the diffs readable in github
Contributor
|
Also show the SRJ/original in the snapshot, it will make it easier to understand |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a per-layer snapshort test for rectdiffpipeline