refactor: consolidate redundant layer transition features in getIntraNodeCrossings #438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NodeCrossings - Simplified getIntraNodeCrossings: Removed the redundant numTransitions return value and the manual numEntryExitLayerChanges counter. Both are now consolidated into a single numEntryExitLayerChanges field derived directly from transitionPairPoints.length. - Updated MultiHeadPolyLineIntraNodeSolver: Aligned the solver with these changes by renaming its internal usage of numTransitions to numEntryExitLayerChanges. - Improved Maintainability: The logic now has a single source of truth for layer-change counts, reducing the risk of divergent values.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
imrishabh18
approved these changes
Dec 22, 2025
seveibar
approved these changes
Dec 23, 2025
Contributor
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
this looks fine but i'm trying to understand your description, isn't this a noop change? Like the functionality is the same? I don't understand in the description how you said we're counting something twice- it seems like this is just a refactor to remove numTransitions?
Contributor
Contributor
Author
|
@seveibar I also removed a variable called |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nutshell: We were counting the layer transition twice;
Simplified getIntraNodeCrossings: Removed the redundant numTransitions return value and the manual numEntryExitLayerChanges counter. Both are now consolidated into a single numEntryExitLayerChanges field derived directly from transitionPairPoints.length.
Updated MultiHeadPolyLineIntraNodeSolver: Aligned the solver with these changes by renaming its internal usage of numTransitions to numEntryExitLayerChanges.
Improved Maintainability: The logic now has a single source of truth for layer-change counts, reducing the risk of divergent values.