Multiple EC_number tags for CDSs, lower case initials in /product descriptions for prokka-1.9.1-testing#18
Open
aleimba wants to merge 8 commits intotseemann:masterfrom
Open
Multiple EC_number tags for CDSs, lower case initials in /product descriptions for prokka-1.9.1-testing#18aleimba wants to merge 8 commits intotseemann:masterfrom
aleimba wants to merge 8 commits intotseemann:masterfrom
Conversation
Author
|
Forgot to mention, in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New pull request to include multiple EC_number tags per CDS with version prokka-1.9.1-testing and some bug fixes
For this purpose the database format was adapted to include several EC_numbers separated by a semicolon, e.g.:
This is included in the necessary database preparations scripts:
prokka-biocyc_to_fasta_dbprokka-genbank_to_fasta_dbprokka-genpept_to_fasta_dbprokka-hamap_to_hmmprokka-uniprot_to_fasta_dbprokkacan handle this format now. As a result a new uniprot database in/db/kingdom/Bacteria/sprotis included.Additionally, a couple of bug fixes:
prokka-hamap_to_hmm(will concatenate result files to 'HAMAP.hmm') andprokka-uniprot_to_fasta_db(divert stdout to '> sprot')prokka-uniprot_to_fasta_db. What is 'if (1)' for? https://github.com/Victorian-Bioinformatics-Consortium/prokka/blob/master/bin/prokka-uniprot_to_fasta_db#L58I removed the condition.
This might warrant a new version, changed it to prokka-1.9.2.-testing. ChangeLog.txt is updated as well.