Clean hh_id in ppathl + add berufsständische Altersvorsorge + add pwealth#74
Open
MImmesberger wants to merge 6 commits intoboilerplatefrom
Open
Clean hh_id in ppathl + add berufsständische Altersvorsorge + add pwealth#74MImmesberger wants to merge 6 commits intoboilerplatefrom
MImmesberger wants to merge 6 commits intoboilerplatefrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
MImmesberger
changed the title
MImmesberger
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Merging ppathl with other modules failed in my pipeline because
hh_idcontained negative ints (missings). All other modules useuint32dtype forhh_id, but inppathlthe dtype was resolved toint32because of the negative ints. This leads to merging errors because pandas tries to assignint32values to auint32column.It might be a good idea to check index columns before merging for dtype consistency, would yield a more readable error.
Also adds berufsständische AV and a pwealth cleaning script.