Add missing feature gate for reverse mappings in PHF implementation#4
Open
krobbi wants to merge 1 commit intottys3:mainfrom
Open
Add missing feature gate for reverse mappings in PHF implementation#4krobbi wants to merge 1 commit intottys3:mainfrom
krobbi wants to merge 1 commit intottys3:mainfrom
Conversation
Previously the library would not compile with PHF enabled and default features disabled due to missing constants in the PHF implementation of get_extensions. This adds the feature gate found in the binary search implementation.
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Previously the library would not compile with PHF enabled and default features disabled due to missing constants in the PHF implementation of get_extensions. This adds the feature gate found in the binary search implementation.
PR Type
Bug fix
Description
Add missing
rev-mapfeature gate to PHF implementationFix compilation error when PHF enabled with default features disabled
Align PHF implementation with binary search implementation
Diagram Walkthrough
File Walkthrough
impl_phf.rs
Add feature gate to get_extensions functionsrc/impl_phf.rs
#[cfg(feature = "rev-map")]attribute toget_extensionsfunctionfeatures