Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility with DeArrow #37

Merged
merged 1 commit into from
May 11, 2024
Merged

Conversation

farcaller
Copy link
Contributor

Fixes #33, works around the issues in #34.

This basically moves the injected button higher the DOM so it doesn't clash with dearrow. Verified with dearrow both missing and present.

@bbilly1
Copy link
Member

bbilly1 commented May 1, 2024

Thanks for taking a look at this. I merged the fix from #35 also pushed some changes for the channel button selector, YT likes to move things around from time to time, requiring this extension to update.

Please merge master into your branch and fix the conflict.

@farcaller
Copy link
Contributor Author

Rebased, cleaned up, verified still functional 👍

@Iliannnn
Copy link

Iliannnn commented May 5, 2024

Nevermind, still bugged with DeArrow. Titles dissapearing (1), other weird bugs when hiding and unhiding modified titles (2, 3, 4 & 5). On Firefox

image
image
image
image
image

@farcaller
Copy link
Contributor Author

Are you sure that's on the rebased version? Because I specifically worked around this issue:

image

And I'd be very curious to see the DOM that caused it.

FWIW, I've been running the patched version from this PR for 4 days with zero issues.

@Iliannnn
Copy link

Iliannnn commented May 5, 2024

Are you sure that's on the rebased version? Because I specifically worked around this issue:

image

And I'd be very curious to see the DOM that caused it.

FWIW, I've been running the patched version from this PR for 4 days with zero issues.

I must installed it wrong to my browser then. Any pointers how you're doing this?

@farcaller
Copy link
Contributor Author

I must installed it wrong to my browser then. Any pointers how you're doing this?

Download the zip from my branch (e.g. https://github.com/farcaller/tubearchivist-browser-extension/archive/refs/heads/dearrow.zip), unzip it, rename either manifest-chrome.json or manifest-firefox.json to just manifest.json, and use the load unpacked installation method for your browser. Be sure to uninstall the official one. You'll need to provide the credentials again in the unpacked version.

@Iliannnn
Copy link

Iliannnn commented May 6, 2024

I must installed it wrong to my browser then. Any pointers how you're doing this?

Download the zip from my branch (e.g. https://github.com/farcaller/tubearchivist-browser-extension/archive/refs/heads/dearrow.zip), unzip it, rename either manifest-chrome.json or manifest-firefox.json to just manifest.json, and use the load unpacked installation method for your browser. Be sure to uninstall the official one. You'll need to provide the credentials again in the unpacked version.

That fixed it. I don't know what happend last time I installed it, but now it's working perfectly. Thanks!

@bbilly1
Copy link
Member

bbilly1 commented May 11, 2024

Nice, thanks for implementing this.

@bbilly1 bbilly1 merged commit c82e493 into tubearchivist:master May 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When used in combination with DeArrow (crowdsourced titles), many titles just show up blank.
3 participants