group: parse membership request notifications #998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
purpshell
reviewed
Dec 16, 2025
Contributor
purpshell
left a comment
purpshell
left a comment
There was a problem hiding this comment.
rebase your commits properly.
guilhermejansen
force-pushed
the
feature/membership-request-events
branch
from
ccac4db to
c0e4b31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parse
created|deleted|revoked_membership_requestsinsidegroup.gousing the same member parser used for add/remove/promote/demoteexpose the parsed JIDs via new
events.GroupInfofields together with the request method, keeping all other handlers untouchedverified against real traffic where membership requests previously entered
UnknownChangesreplayed group notifications that contained
created_membership_requestsandrevoked_membership_requestsand confirmed the new fields are populated while other updates (join/leave/promote) still behave as before