Enabling ring.Poly argument to bgv.Encoder.Encode#572
Open
ChristianMct wants to merge 2 commits intotuneinsight:mainfrom
Open
Enabling ring.Poly argument to bgv.Encoder.Encode#572ChristianMct wants to merge 2 commits intotuneinsight:mainfrom
ring.Poly argument to bgv.Encoder.Encode#572ChristianMct wants to merge 2 commits intotuneinsight:mainfrom
Conversation
lehugueni
approved these changes
Apr 13, 2026
Comment on lines
+90
to
+91
| // fmt.Println("have", values[:10]) | ||
| // fmt.Println("want", want[:10]) |
Contributor
There was a problem hiding this comment.
Suggested change
| // fmt.Println("have", values[:10]) | |
| // fmt.Println("want", want[:10]) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I stumbled over these two limitations with the current BGV encoder:
pt.IsBatched=false.IntegerSliceparameters, while it could be useful to many applications to encryptring.Polydirectly. It is possible with the current API but is quite tricky and undocumented.This PR address these issues by defining the missing cases and encoder semantic. It is currently done as a minimal change, but a more sequential implementation of the Encoding workflow could be considered. The PR also adds a
ckkstest case for issue 1, even thoughckks.Encodercurrently behaves as expected in this case.