-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation page: mkdocs & GitHub pages #449
Conversation
82f046d
to
4932a58
Compare
Add mkdocs as a documentation framework for FawltyDeps. Update dependencies with a new `docs` dependencies group. Add material-mkdocs.
6c410db
to
ce7a0ab
Compare
b7f16d5
to
dfb1799
Compare
Create content for the documentation page
5870a05
to
d218819
Compare
Content of README should be shorter. Information suplocated in `docs` is removed.
d218819
to
a7e8e0e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big review, lots of comments, but don't be discouraged! I love the look of the docs website, and I'm happy to help in any way I can to get this merged! ❤️
Rewrite front page of the documentation as per @jherland's suggestion Co-authored-by: Johan Herland <[email protected]>
Co-authored-by: Johan Herland <[email protected]>
…eference to usage and configuration
Provide more detail explaining why/when to use each of these command-line options. Co-authored-by: Johan Herland <[email protected]>
Co-authored-by: Johan Herland <[email protected]>
Co-authored-by: Johan Herland <[email protected]>
Poetry v2 drops support for Python v3.8 which we are still using.
953ca04
to
ecacda5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took another look now, and except for two open questions (#449 (comment) and #449 (comment)) I think this is ready to get merged. 🎉
I also notice that the preview of the documentation page on https://tweag.github.io/FawltyDeps/ does not appear to be updated with the latest changes (for one, the menu structure on the left-hand side does not reflect the nav
structure in mkdocs.yml
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed some misrendered lists in the new deployed docs. Otherwise, I think this is ready to merge. 🚀
Co-authored-by: Johan Herland <[email protected]>
Co-authored-by: Johan Herland <[email protected]>
Co-authored-by: Johan Herland <[email protected]>
In this PR, a documentation page using mkdocs and deployed on GitHub pages is added.
Documentation content
Documentation page is based on the content available in the current README.md file. The content is split and grouped according to diataxis principles to provide explanations, usage guide and FAQs for FawltyDeps.
To build documentation, mkdocs with mkdocs-material are used due to simplicity and wide support.
Deployment
Documentation page is deployed on GitHub pages (see Settings -> Pages) and is using the content of gh-pages branch.
Content of gh-pages is automatically created with GitHub Action, following the documentation of mkdocs-material.
Local tests
First, install docs dependencies:
Then build and serve locally: