Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a collection of build files that work with the given WORKSPACE
file. This should allow the user to run
bazel test //...
which willbuild run all tests in
inline-java
: as of time of writing, this isspec tests in
inline-java
andjvm-streaming
.need to have all the packages available to GHC at WORKSPACE level
then we also need to know them at BUILD level. We can't just define
them in WORKSPACE and refer to them from BUILD as WORKSPACE only
works in current project: if user wants to use inline-java from
another project, the WORKSPACE file here is irrelevant: indeed
they'll have to define all these things in their own WORKSPACE.
Old PR description below. Note that nearly all points there have now been resolved due to better
rules_haskell
/rules_nixpkgs
🎊This is a collection of build files that work with the given WORKSPACE
file. This should allow the user to run
bazel run //:spec
which willbuild inline-java and run the spec tests.
set.
nix. Neither exposes both:
Consider exposing all files in a filegroup rules_nixpkgs#9
need to have all the packages available to GHC at WORKSPACE level
then we also need to know them at BUILD level. We can't just define
them in WORKSPACE and refer to them from BUILD as WORKSPACE only
works in current project: if user wants to use inline-java from
another project, the WORKSPACE file here is irrelevant: indeed
they'll have to define all these things in their own WORKSPACE.
rules_nixpkgs
commit points at a temporary branch which includeschanges from two outstanding PRs, both of which are needed to build
inline-java
spec
target would be better as somehaskell_test
once thatexists
libjvm.so and maybe libjni.so but we don't have granular control
over the filegroup so we end up using every shared lib in openjdk
package which is not ideal.